Skip to content

fix: MySQL slice shadowing database/sql import #2332

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 20, 2023
Merged

fix: MySQL slice shadowing database/sql import #2332

merged 2 commits into from
Jun 20, 2023

Conversation

@LudovicDebost
Copy link
Contributor

@LudovicDebost LudovicDebost commented Jun 16, 2023 •
edited
Loading

The generated code use a var named sql but when the query return a database/sql type like sql.NullString then the var is shadowing the import.

Fixes #1816
@kyleconroy
Copy link
Collaborator

We'll have the same issue is someone uses a type in a query package, but that's not going to happen nearly as much as sql.
@kyleconroy kyleconroy merged commit 3b21fdf into sqlc-dev:main Jun 20, 2023
@LudovicDebost LudovicDebost deleted the fix-mysql-slice branch June 21, 2023 06:24
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
@LudovicDebost
fix: MySQL slice shadowing database/sql import (sqlc-dev#2332)
2fa0268 
* fix: MySQL slice with database/sql type
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@LudovicDebost @kyleconroy