Skip to content

fix(engine/sqlite): add location info to sqlite ast #2298

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 7, 2023
Merged

fix(engine/sqlite): add location info to sqlite ast #2298

merged 1 commit into from
Jun 7, 2023

Conversation

@orisano
Copy link
Contributor

@orisano orisano commented Jun 6, 2023

Sorry, #2250 will panic if Location is not set properly.
Fixed sqlite convert because many nodes don't have Location set properly.
@orisano orisano changed the title fix: add location info to sqlite ast Jun 6, 2023
@kyleconroy kyleconroy merged commit 9c64cfa into sqlc-dev:main Jun 7, 2023
@kyleconroy
Copy link
Collaborator

Thanks for the quick fix! We should also probably make sure that we never pass -1 to strings.Repeat
alfonsodev pushed a commit to ExponentiaTeam/sqlc that referenced this pull request Oct 13, 2025
@orisano
fix: add location info to sqlite ast (sqlc-dev#2298)
d887331
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

2 participants

@orisano @kyleconroy