Skip to content

Fix issue with Node 23 #2813

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix issue with Node 23 #2813

wants to merge 1 commit into from

Conversation

@fogodev
Copy link
Member

@fogodev fogodev commented Nov 16, 2024

I was having issues trying to launch spacedrive in dev mode due to updating my Node to version 23. So I tried to fix it, changing the desktop app to use ES Modules instead of CommonJS.

I'm not too sure as TS isn't much my thing, so this PR needs a proper reviewing from some TS guys.
@fogodev fogodev requested a review from a team as a code owner November 16, 2024 18:59
@vercel
Copy link

vercel bot commented Nov 16, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
spacedrive-landing ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 7:03pm
spacedrive-web ✅ Ready (Inspect) Visit Preview 💬 Add feedback Nov 16, 2024 7:03pm
iLynxcat
iLynxcat reviewed Nov 17, 2024
View reviewed changes
Copy link
Contributor

@iLynxcat iLynxcat left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tailwind supports .config.ts now, we should test to see if it works in our environment if we’re already renaming it
@iLynxcat
Copy link
Contributor

We have a nvmrc, though — we should update this to 23 if it’s supported everywhere or you should use a node version manager (like fnm, which I use) to automatically switch to the correct Node version https://github.com/spacedriveapp/spacedrive/blob/main/.nvmrc
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants

@fogodev @iLynxcat