Integration test framework files for hotpot #999
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…IntegrationTest
Shruthi-1MN
reviewed
Sep 3, 2019
| // ctx, kv := utils.ConnectToDB() | ||
| ret := utils.GetValueByKeyFromDB(fId) | ||
| Expect(ret).ShouldNot(Equal(OPERATION_FAILED)) | ||
| textFound := utils.ReadAndFindTextInFile("C:/go/src/opensds/opensds/test/integration/utils/output.json", "17c60641-63c9-4f7f-992a-c0dcd9abd502") |
There was a problem hiding this comment.
Which function writing this log file? Those entries should be written to this log file somewhere, where is that?
There was a problem hiding this comment.
this path is just for testing ... In actual testcase, what we want to find in log, need to give the log file path and text to find
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
The PR is for Integration test framework files using ginkgo
PR contains HTTPHelper (that connects via http and create http call), DBHelper ( which connects to dB and get data), LogReader ( which reads log file and do asseration)
Special notes for your reviewer:
IP of server need to be updated for OpenSDS hotpot installation path
Release note:
NONE
-->