Retry: Handle DNSError when network message different - #7050
Closed
ardaguclu wants to merge 3 commits into
Closed
Conversation
Contributor
|
Is this something you are able to reproduce? Can you try to do so on 16.04, where we get a different error family for network errors? |
Contributor
Author
|
On Ubuntu 18.04 and when the network connection is turned off, installation command returns;
On Ubuntu 16.04 (running as lxd container);
I have not tested trying to install from localhost issued the launchpad link. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
As mentioned below launchpad link; in some cases when network connection does not exist, snap install command returns unclear message. Thus, I added "server misbehaving" check to make it clear to the user when there is possible network connectivity problem and its unit test.
https://bugs.launchpad.net/snapd/+bug/1794006