deltas: Improved message returned when delta is too big - #1345
Merged
come-maiz merged 4 commits intoJun 22, 2017
Conversation
|
Thanks @gsilvapt. Some missing things here:
|
Contributor
Author
|
Thanks for reviewing this PR, @ElOpio. I've signed the license agreement. Never saw this step before :) What can I do about the static error? Judging the return output, I can simply add the line missing? |
|
yes, you are missing one empty line. |
Contributor
Author
|
I didn't notice Sergio had merged to the master, so I had this extra commit 55ad8bc which is the same update. Hopefully this is all good now. |
come-maiz
approved these changes
Jun 14, 2017
come-maiz
left a comment
There was a problem hiding this comment.
Thanks @gsilvapt!
@kyrofa or @kalikiana, please make the second review here.
kyrofa
approved these changes
Jun 14, 2017
kyrofa
left a comment
Contributor
There was a problem hiding this comment.
This is excellent, thank you!
|
@gsilvapt it seems you made your email private in github, and that makes the automatic CLA check to fail because it can't find your email. |
Contributor
Author
|
@ElOpio I've made it public as of now. Sorry. :-)
On Thu, 15 Jun 2017 at 04:39 Leo Arias ***@***.***> wrote:
@gsilvapt <https://github.com/gsilvapt> it seems you made your email
private in github, and that makes the automatic CLA check to fail because
it can't find your email.
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#1345 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AHbQPLgKNk2kRerGjl6R2j-MWeLei-Gjks5sEKd5gaJpZM4NtNu9>
.
--
Best Regards / Obrigado e com os melhores cumprimentos,
Gustavo Silva
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Improved the big delta warning/error message when the user is trying to push changes, making it display the size of the delta before pushing the full snap.
LP: 1681692