Skip to content

deltas: Improved message returned when delta is too big - #1345

Merged
come-maiz merged 4 commits into
canonical:masterfrom
gsilvapt:bug/1681692/big_delta_message
Jun 22, 2017
Merged

deltas: Improved message returned when delta is too big#1345
come-maiz merged 4 commits into
canonical:masterfrom
gsilvapt:bug/1681692/big_delta_message

Conversation

@gsilvapt

@gsilvapt gsilvapt commented Jun 1, 2017

Copy link
Copy Markdown
Contributor

Improved the big delta warning/error message when the user is trying to push changes, making it display the size of the delta before pushing the full snap.

LP: 1681692

@come-maiz

Copy link
Copy Markdown

Thanks @gsilvapt. Some missing things here:

@gsilvapt

gsilvapt commented Jun 6, 2017

Copy link
Copy Markdown
Contributor Author

Thanks for reviewing this PR, @ElOpio.

I've signed the license agreement. Never saw this step before :)

What can I do about the static error? Judging the return output, I can simply add the line missing?

@come-maiz

Copy link
Copy Markdown

yes, you are missing one empty line.

@gsilvapt

gsilvapt commented Jun 7, 2017

Copy link
Copy Markdown
Contributor Author

I didn't notice Sergio had merged to the master, so I had this extra commit 55ad8bc which is the same update. Hopefully this is all good now.

@come-maiz come-maiz left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @gsilvapt!
@kyrofa or @kalikiana, please make the second review here.

@kyrofa kyrofa left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is excellent, thank you!

@come-maiz

Copy link
Copy Markdown

@gsilvapt it seems you made your email private in github, and that makes the automatic CLA check to fail because it can't find your email.

@gsilvapt

gsilvapt commented Jun 15, 2017 via email

Copy link
Copy Markdown
Contributor Author
@come-maiz
come-maiz merged commit 6295fd8 into canonical:master Jun 22, 2017
@kyrofa kyrofa added this to the 2.32 milestone Jun 23, 2017
kalikiana pushed a commit to kalikiana/snapcraft that referenced this pull request Aug 3, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

3 participants