Skip to content

Commit deeaa71

Browse files
boris779diemol
andauthored
Fix added missing quotation marks in examples (#10250)
Co-authored-by: Diego Molina <diemol@users.noreply.github.com>
1 parent 2decee4 commit deeaa71

File tree

5 files changed

+12
-12
lines changed

5 files changed

+12
-12
lines changed

‎java/src/org/openqa/selenium/grid/log/LoggingFlags.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -66,17 +66,17 @@ public class LoggingFlags implements HasRoles {
6666

6767
@Parameter(description = "File to write out logs. "
6868
+ "Ensure the file path is compatible with the operating system's file path.\n"
69-
+ "Windows path example : \\\\path\\to\\file\\gridlog.log OR "
69+
+ "# Windows path example : \\\\path\\to\\file\\gridlog.log OR "
7070
+ "C:\\path\\path\\to\\file\\gridlog.log \n"
71-
+ "Linux/Unix/MacOS path example : /path/to/file/gridlog.log \n"
71+
+ "# Linux/Unix/MacOS path example : /path/to/file/gridlog.log \n"
7272
, names = "--log", arity = 1)
7373
@ConfigValue(section = LOGGING_SECTION, name = "log-file", example = {"'\\\\path\\to\\file\\gridlog.log'",
7474
"'C:\\path\\path\\to\\file\\gridlog.log'",
7575
"'/path/to/file/gridlog.log'"})
7676
private String logFile;
7777

7878
@Parameter(description = "Log encoding", names = "--log-encoding", arity = 1)
79-
@ConfigValue(section = LOGGING_SECTION, name = "log-encoding", example = "UTF-8")
79+
@ConfigValue(section = LOGGING_SECTION, name = "log-encoding", example = "\"UTF-8\"")
8080
private String logEncoding;
8181

8282
@Parameter(description =

‎java/src/org/openqa/selenium/grid/node/config/NodeFlags.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -145,9 +145,9 @@ public class NodeFlags implements HasRoles {
145145
"display-name = \"Firefox Nightly\"\n" +
146146
"webdriver-executable = \"/usr/local/bin/geckodriver\"\n" +
147147
"max-sessions = 2\n" +
148-
"stereotype = \"{\"browserName\": \"firefox\", \"browserVersion\": \"86\", " +
149-
"\"moz:firefoxOptions\": " +
150-
"{\"binary\":\"/Applications/Firefox Nightly.app/Contents/MacOS/firefox-bin\"}}\"")
148+
"stereotype = \"{\\\"browserName\\\": \\\"firefox\\\", \\\"browserVersion\\\": \\\"86\\\", " +
149+
"\\\"moz:firefoxOptions\\\": " +
150+
"{\\\"binary\\\":\\\"/Applications/Firefox Nightly.app/Contents/MacOS/firefox-bin\\\"}}\"")
151151
public List<String> driverConfiguration;
152152

153153
@Parameter(

‎java/src/org/openqa/selenium/grid/node/docker/DockerFlags.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -40,7 +40,7 @@ public class DockerFlags implements HasRoles {
4040
names = {"--docker-url"},
4141
description = "URL for connecting to the docker daemon"
4242
)
43-
@ConfigValue(section = DockerOptions.DOCKER_SECTION, name = "url", example = DockerOptions.DEFAULT_DOCKER_URL)
43+
@ConfigValue(section = DockerOptions.DOCKER_SECTION, name = "url", example = "\"" + DockerOptions.DEFAULT_DOCKER_URL + "\"")
4444
private String dockerUrl;
4545

4646
@Parameter(
@@ -81,7 +81,7 @@ public class DockerFlags implements HasRoles {
8181
names = {"--docker-assets-path"},
8282
description = "Absolute path where assets will be stored"
8383
)
84-
@ConfigValue(section = DockerOptions.DOCKER_SECTION, name = "assets-path", example = DockerOptions.DEFAULT_ASSETS_PATH)
84+
@ConfigValue(section = DockerOptions.DOCKER_SECTION, name = "assets-path", example = "\"" + DockerOptions.DEFAULT_ASSETS_PATH + "\"")
8585
private String assetsPath;
8686

8787
@Override

‎java/src/org/openqa/selenium/grid/node/relay/RelayFlags.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -54,16 +54,16 @@ public class RelayFlags implements HasRoles {
5454
prefixed = true,
5555
example = "\n" +
5656
"max-sessions = 2\n" +
57-
"stereotype = \"{\"browserName\": \"safari\", \"platformName\": \"iOS\", " +
58-
"\"appium:platformVersion\": \"14.5\" }}\"")
57+
"stereotype = \"{\\\"browserName\\\": \\\"safari\\\", \\\"platformName\\\": \\\"iOS\\\", " +
58+
"\\\"appium:platformVersion\\\": \\\"14.5\\\" }}\"")
5959
public List<String> driverConfiguration;
6060

6161
@Parameter(
6262
names = {"--service-url"},
6363
description = "URL for connecting to the service that supports WebDriver commands, "
6464
+ "like an Appium server or a cloud service."
6565
)
66-
@ConfigValue(section = RELAY_SECTION, name = "url", example = "http://localhost:4723")
66+
@ConfigValue(section = RELAY_SECTION, name = "url", example = "\"http://localhost:4723\"")
6767
private String serviceUrl;
6868
@Parameter(
6969
names = {"--service-host"},

‎java/src/org/openqa/selenium/grid/server/EventBusFlags.java

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -64,7 +64,7 @@ public class EventBusFlags implements HasRoles {
6464
@ConfigValue(
6565
section = EVENTS_SECTION,
6666
name = "implementation",
67-
example = "org.openqa.selenium.events.zeromq.ZeroMqEventBus")
67+
example = "\"org.openqa.selenium.events.zeromq.ZeroMqEventBus\"")
6868
private String implementation;
6969

7070
@Override

0 commit comments

Comments
 (0)