Skip to content

Commit dad6f8c

Browse files
SinghHrmnpujagani
andauthored
[py] Update extension in the tests to use the common extensions (#10478)
* [py] Update extension in the tests to use the common extensions Removes C-py tag from #10266 * fix: updated py BUILD.bazel merge issue Co-authored-by: Puja Jagani <puja.jagani93@gmail.com>
1 parent aa88b5c commit dad6f8c

File tree

3 files changed

+11
-9
lines changed

3 files changed

+11
-9
lines changed

‎common/extensions/BUILD.bazel

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -10,6 +10,7 @@ filegroup(
1010
"//java/test/org/openqa/selenium/environment:__pkg__",
1111
"//java/test/org/openqa/selenium/firefox:__pkg__",
1212
"//javascript/node/selenium-webdriver:__pkg__",
13+
"//py:__pkg__",
1314
],
1415
)
1516

@@ -19,5 +20,6 @@ exports_files(
1920
],
2021
visibility = [
2122
"//java/test/org/openqa/selenium/firefox:__pkg__",
23+
"//py:__pkg__",
2224
],
2325
)

‎py/BUILD.bazel

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -67,8 +67,8 @@ copy_file(
6767

6868
copy_file(
6969
name = "favourite_color",
70-
src = "//third_party/firebug:favourite_colour-1.1-an+fx.xpi",
71-
out = "test/selenium/webdriver/firefox/favourite_colour-1.1-an+fx.xpi",
70+
src = "//common/extensions:webextensions-selenium-example.xpi",
71+
out = "test/selenium/webdriver/firefox/webextensions-selenium-example.xpi",
7272
)
7373

7474
py_library(
@@ -345,7 +345,7 @@ py_test_suite(
345345
"--driver=firefox",
346346
],
347347
data = [
348-
"//third_party/firebug:favourite_colour-1.1-an+fx.xpi",
348+
"//common/extensions",
349349
],
350350
tags = [
351351
"no-sandbox",
@@ -370,7 +370,7 @@ py_test_suite(
370370
],
371371
data = [
372372
"//java/src/org/openqa/selenium/grid:selenium_server_deploy.jar",
373-
"//third_party/firebug:favourite_colour-1.1-an+fx.xpi",
373+
"//common/extensions",
374374
],
375375
tags = [
376376
"no-sandbox",

‎py/test/selenium/webdriver/firefox/ff_installs_addons_tests.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -22,23 +22,23 @@
2222

2323
def test_install_addon_temporary(driver):
2424
extension = os.path.join(os.path.dirname(os.path.abspath(__file__)),
25-
'favourite_colour-1.1-an+fx.xpi')
25+
'webextensions-selenium-example.xpi')
2626

2727
id = driver.install_addon(extension, True)
28-
assert id == 'favourite-colour-examples@mozilla.org'
28+
assert id == 'webextensions-selenium-example@example.com'
2929

3030

3131
def test_install_addon(driver):
3232
extension = os.path.join(os.path.dirname(os.path.abspath(__file__)),
33-
'favourite_colour-1.1-an+fx.xpi')
33+
'webextensions-selenium-example.xpi')
3434

3535
id = driver.install_addon(extension, False)
36-
assert id == 'favourite-colour-examples@mozilla.org'
36+
assert id == 'webextensions-selenium-example@example.com'
3737

3838

3939
def test_uninstall_addon(driver):
4040
extension = os.path.join(os.path.dirname(os.path.abspath(__file__)),
41-
'favourite_colour-1.1-an+fx.xpi')
41+
'webextensions-selenium-example.xpi')
4242

4343
id = driver.install_addon(extension)
4444
try:

0 commit comments

Comments
 (0)