Skip to content

Commit d3a0201

Browse files
BusHeroAutomatedTester
BusHero
and
AutomatedTester
authored
Added DepricationWarning to the warnings.warn methods inside the find_element_by_x methods (#10575)
* Added DepricationWarning to the warnings.warn methods inside the find_element_by_x methods * Added stacklevel=2 to the warn.warnings * Removed the trailing whitespace Co-authored-by: David Burns <david.burns@theautomatedtester.co.uk>
1 parent 8ddadc6 commit d3a0201

File tree

1 file changed

+46
-16
lines changed

1 file changed

+46
-16
lines changed

‎py/selenium/webdriver/remote/webelement.py

Lines changed: 46 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -185,7 +185,9 @@ def find_element_by_id(self, id_):
185185
186186
foo_element = element.find_element_by_id('foo')
187187
"""
188-
warnings.warn("find_element_by_id is deprecated. Please use find_element(by=By.ID, value=id_) instead")
188+
warnings.warn("find_element_by_id is deprecated. Please use find_element(by=By.ID, value=id_) instead",
189+
DeprecationWarning,
190+
stacklevel=2)
189191
return self.find_element(by=By.ID, value=id_)
190192

191193
def find_elements_by_id(self, id_):
@@ -204,7 +206,9 @@ def find_elements_by_id(self, id_):
204206
205207
elements = element.find_elements_by_id('foo')
206208
"""
207-
warnings.warn("find_elements_by_id is deprecated. Please use find_elements(by=By.ID, value=id_) instead")
209+
warnings.warn("find_elements_by_id is deprecated. Please use find_elements(by=By.ID, value=id_) instead",
210+
DeprecationWarning,
211+
stacklevel=2)
208212
return self.find_elements(by=By.ID, value=id_)
209213

210214
def find_element_by_name(self, name):
@@ -224,7 +228,9 @@ def find_element_by_name(self, name):
224228
225229
element = element.find_element_by_name('foo')
226230
"""
227-
warnings.warn("find_element_by_name is deprecated. Please use find_element(by=By.NAME, value=name) instead")
231+
warnings.warn("find_element_by_name is deprecated. Please use find_element(by=By.NAME, value=name) instead",
232+
DeprecationWarning,
233+
stacklevel=2)
228234
return self.find_element(by=By.NAME, value=name)
229235

230236
def find_elements_by_name(self, name):
@@ -242,7 +248,9 @@ def find_elements_by_name(self, name):
242248
243249
elements = element.find_elements_by_name('foo')
244250
"""
245-
warnings.warn("find_elements_by_name is deprecated. Please use find_elements(by=By.NAME, value=name) instead")
251+
warnings.warn("find_elements_by_name is deprecated. Please use find_elements(by=By.NAME, value=name) instead",
252+
DeprecationWarning,
253+
stacklevel=2)
246254
return self.find_elements(by=By.NAME, value=name)
247255

248256
def find_element_by_link_text(self, link_text):
@@ -262,7 +270,9 @@ def find_element_by_link_text(self, link_text):
262270
263271
element = element.find_element_by_link_text('Sign In')
264272
"""
265-
warnings.warn("find_element_by_link_text is deprecated. Please use find_element(by=By.LINK_TEXT, value=link_text) instead")
273+
warnings.warn("find_element_by_link_text is deprecated. Please use find_element(by=By.LINK_TEXT, value=link_text) instead",
274+
DeprecationWarning,
275+
stacklevel=2)
266276
return self.find_element(by=By.LINK_TEXT, value=link_text)
267277

268278
def find_elements_by_link_text(self, link_text):
@@ -280,7 +290,9 @@ def find_elements_by_link_text(self, link_text):
280290
281291
elements = element.find_elements_by_link_text('Sign In')
282292
"""
283-
warnings.warn("find_elements_by_link_text is deprecated. Please use find_elements(by=By.LINK_TEXT, value=text) instead")
293+
warnings.warn("find_elements_by_link_text is deprecated. Please use find_elements(by=By.LINK_TEXT, value=text) instead",
294+
DeprecationWarning,
295+
stacklevel=2)
284296
return self.find_elements(by=By.LINK_TEXT, value=link_text)
285297

286298
def find_element_by_partial_link_text(self, link_text):
@@ -300,7 +312,9 @@ def find_element_by_partial_link_text(self, link_text):
300312
301313
element = element.find_element_by_partial_link_text('Sign')
302314
"""
303-
warnings.warn("find_element_by_partial_link_text is deprecated. Please use find_element(by=By.PARTIAL_LINK_TEXT, value=link_text) instead")
315+
warnings.warn("find_element_by_partial_link_text is deprecated. Please use find_element(by=By.PARTIAL_LINK_TEXT, value=link_text) instead",
316+
DeprecationWarning,
317+
stacklevel=2)
304318
return self.find_element(by=By.PARTIAL_LINK_TEXT, value=link_text)
305319

306320
def find_elements_by_partial_link_text(self, link_text):
@@ -318,7 +332,9 @@ def find_elements_by_partial_link_text(self, link_text):
318332
319333
elements = element.find_elements_by_partial_link_text('Sign')
320334
"""
321-
warnings.warn("find_elements_by_partial_link_text is deprecated. Please use find_elements(by=By.PARTIAL_LINK_TEXT, value=link_text) instead")
335+
warnings.warn("find_elements_by_partial_link_text is deprecated. Please use find_elements(by=By.PARTIAL_LINK_TEXT, value=link_text) instead",
336+
DeprecationWarning,
337+
stacklevel=2)
322338
return self.find_elements(by=By.PARTIAL_LINK_TEXT, value=link_text)
323339

324340
def find_element_by_tag_name(self, name):
@@ -338,7 +354,9 @@ def find_element_by_tag_name(self, name):
338354
339355
element = element.find_element_by_tag_name('h1')
340356
"""
341-
warnings.warn("find_element_by_tag_name is deprecated. Please use find_element(by=By.TAG_NAME, value=name) instead")
357+
warnings.warn("find_element_by_tag_name is deprecated. Please use find_element(by=By.TAG_NAME, value=name) instead",
358+
DeprecationWarning,
359+
stacklevel=2)
342360
return self.find_element(by=By.TAG_NAME, value=name)
343361

344362
def find_elements_by_tag_name(self, name):
@@ -356,7 +374,9 @@ def find_elements_by_tag_name(self, name):
356374
357375
elements = element.find_elements_by_tag_name('h1')
358376
"""
359-
warnings.warn("find_elements_by_tag_name is deprecated. Please use find_elements(by=By.TAG_NAME, value=name) instead")
377+
warnings.warn("find_elements_by_tag_name is deprecated. Please use find_elements(by=By.TAG_NAME, value=name) instead",
378+
DeprecationWarning,
379+
stacklevel=2)
360380
return self.find_elements(by=By.TAG_NAME, value=name)
361381

362382
def find_element_by_xpath(self, xpath):
@@ -390,7 +410,9 @@ def find_element_by_xpath(self, xpath):
390410
391411
element = element.find_element_by_xpath('//div/td[1]')
392412
"""
393-
warnings.warn("find_element_by_xpath is deprecated. Please use find_element(by=By.XPATH, value=xpath) instead")
413+
warnings.warn("find_element_by_xpath is deprecated. Please use find_element(by=By.XPATH, value=xpath) instead",
414+
DeprecationWarning,
415+
stacklevel=2)
394416
return self.find_element(by=By.XPATH, value=xpath)
395417

396418
def find_elements_by_xpath(self, xpath):
@@ -423,7 +445,9 @@ def find_elements_by_xpath(self, xpath):
423445
elements = element.find_elements_by_xpath("//div[contains(@class, 'foo')]")
424446
425447
"""
426-
warnings.warn("find_elements_by_xpath is deprecated. Please use find_elements(by=By.XPATH, value=xpath) instead")
448+
warnings.warn("find_elements_by_xpath is deprecated. Please use find_elements(by=By.XPATH, value=xpath) instead",
449+
DeprecationWarning,
450+
stacklevel=2)
427451
return self.find_elements(by=By.XPATH, value=xpath)
428452

429453
def find_element_by_class_name(self, name):
@@ -443,7 +467,9 @@ def find_element_by_class_name(self, name):
443467
444468
element = element.find_element_by_class_name('foo')
445469
"""
446-
warnings.warn("find_element_by_class_name is deprecated. Please use find_element(by=By.CLASS_NAME, value=name) instead")
470+
warnings.warn("find_element_by_class_name is deprecated. Please use find_element(by=By.CLASS_NAME, value=name) instead",
471+
DeprecationWarning,
472+
stacklevel=2)
447473
return self.find_element(by=By.CLASS_NAME, value=name)
448474

449475
def find_elements_by_class_name(self, name):
@@ -461,7 +487,7 @@ def find_elements_by_class_name(self, name):
461487
462488
elements = element.find_elements_by_class_name('foo')
463489
"""
464-
warnings.warn("find_elements_by_class_name is deprecated. Please use find_elements(by=By.CLASS_NAME, value=name) instead")
490+
warnings.warn("find_elements_by_class_name is deprecated. Please use find_elements(by=By.CLASS_NAME, value=name) instead", DeprecationWarning)
465491
return self.find_elements(by=By.CLASS_NAME, value=name)
466492

467493
def find_element_by_css_selector(self, css_selector):
@@ -481,7 +507,9 @@ def find_element_by_css_selector(self, css_selector):
481507
482508
element = element.find_element_by_css_selector('#foo')
483509
"""
484-
warnings.warn("find_element_by_css_selector is deprecated. Please use find_element(by=By.CSS_SELECTOR, value=css_selector) instead")
510+
warnings.warn("find_element_by_css_selector is deprecated. Please use find_element(by=By.CSS_SELECTOR, value=css_selector) instead",
511+
DeprecationWarning,
512+
stacklevel=2)
485513
return self.find_element(by=By.CSS_SELECTOR, value=css_selector)
486514

487515
def find_elements_by_css_selector(self, css_selector):
@@ -499,7 +527,9 @@ def find_elements_by_css_selector(self, css_selector):
499527
500528
elements = element.find_elements_by_css_selector('.foo')
501529
"""
502-
warnings.warn("find_elements_by_css_selector is deprecated. Please use find_elements(by=By.CSS_SELECTOR, value=css_selector) instead")
530+
warnings.warn("find_elements_by_css_selector is deprecated. Please use find_elements(by=By.CSS_SELECTOR, value=css_selector) instead",
531+
DeprecationWarning,
532+
stacklevel=2)
503533
return self.find_elements(by=By.CSS_SELECTOR, value=css_selector)
504534

505535
def send_keys(self, *value) -> None:

0 commit comments

Comments
 (0)