Skip to content

Commit ca39d6f

Browse files
committed
[js] do not convert tag name to css selector
1 parent 2921929 commit ca39d6f

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

‎javascript/node/selenium-webdriver/lib/by.js

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -225,7 +225,7 @@ class By {
225225
* @return {!By} The new locator.
226226
*/
227227
static tagName(name) {
228-
return By.css(name)
228+
return new By('tag name', name)
229229
}
230230

231231
/**

‎javascript/node/selenium-webdriver/test/lib/by_test.js

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -93,7 +93,7 @@ describe('by', function () {
9393

9494
let expected = {
9595
relative: {
96-
root: { 'css selector': 'p' },
96+
root: { 'tag name': 'p' },
9797
filters: [
9898
{ kind: 'above', args: [{ 'css selector': '*[name="foobar"]' }] },
9999
],
@@ -163,7 +163,7 @@ describe('by', function () {
163163

164164
it('accepts tagName', function () {
165165
let locator = by.checkedLocator({ tagName: 'div' })
166-
assert.strictEqual('css selector', locator.using)
166+
assert.strictEqual('tag name', locator.using)
167167
assert.strictEqual('div', locator.value)
168168
})
169169

‎javascript/node/selenium-webdriver/test/lib/webdriver_test.js

Lines changed: 4 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -762,7 +762,7 @@ describe('WebDriver', function () {
762762

763763
it('customLocator', function () {
764764
let executor = new FakeExecutor()
765-
.expect(CName.FIND_ELEMENTS, { using: 'css selector', value: 'a' })
765+
.expect(CName.FIND_ELEMENTS, { using: 'css selector', value: '.a' })
766766
.andReturnSuccess([
767767
WebElement.buildId('foo'),
768768
WebElement.buildId('bar'),
@@ -774,7 +774,7 @@ describe('WebDriver', function () {
774774
const driver = executor.createDriver()
775775
const element = driver.findElement(function (d) {
776776
assert.strictEqual(driver, d)
777-
return d.findElements(By.tagName('a'))
777+
return d.findElements(By.className('a'))
778778
})
779779
return element.click()
780780
})
@@ -797,13 +797,13 @@ describe('WebDriver', function () {
797797
it('returnsMultipleElements', function () {
798798
const ids = ['foo', 'bar', 'baz']
799799
let executor = new FakeExecutor()
800-
.expect(CName.FIND_ELEMENTS, { using: 'css selector', value: 'a' })
800+
.expect(CName.FIND_ELEMENTS, { using: 'css selector', value: '.a' })
801801
.andReturnSuccess(ids.map(WebElement.buildId))
802802
.end()
803803

804804
const driver = executor.createDriver()
805805
return driver
806-
.findElements(By.tagName('a'))
806+
.findElements(By.className('a'))
807807
.then(function (elements) {
808808
return Promise.all(
809809
elements.map(function (e) {

0 commit comments

Comments
 (0)