Skip to content

Commit bf6bffb

Browse files
committed
[java] Enabling a couple of Firefox tests
And disabling a Chrome test after reporting the bug to ChromeDriver.
1 parent 4f0e3d7 commit bf6bffb

File tree

2 files changed

+24
-24
lines changed

2 files changed

+24
-24
lines changed

‎java/test/org/openqa/selenium/PageLoadingTest.java

Lines changed: 17 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,20 @@
1717

1818
package org.openqa.selenium;
1919

20+
import org.junit.Test;
21+
import org.openqa.selenium.remote.CapabilityType;
22+
import org.openqa.selenium.support.ui.WebDriverWait;
23+
import org.openqa.selenium.testing.Ignore;
24+
import org.openqa.selenium.testing.JUnit4TestBase;
25+
import org.openqa.selenium.testing.NeedsFreshDriver;
26+
import org.openqa.selenium.testing.NoDriverAfterTest;
27+
import org.openqa.selenium.testing.NoDriverBeforeTest;
28+
import org.openqa.selenium.testing.NotYetImplemented;
29+
import org.openqa.selenium.testing.SwitchToTopAfterTest;
30+
31+
import java.time.Duration;
32+
import java.util.Set;
33+
2034
import static org.assertj.core.api.Assertions.assertThat;
2135
import static org.assertj.core.api.Assertions.assertThatCode;
2236
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
@@ -35,20 +49,6 @@
3549
import static org.openqa.selenium.testing.drivers.Browser.IE;
3650
import static org.openqa.selenium.testing.drivers.Browser.SAFARI;
3751

38-
import org.junit.Test;
39-
import org.openqa.selenium.remote.CapabilityType;
40-
import org.openqa.selenium.support.ui.WebDriverWait;
41-
import org.openqa.selenium.testing.Ignore;
42-
import org.openqa.selenium.testing.JUnit4TestBase;
43-
import org.openqa.selenium.testing.NeedsFreshDriver;
44-
import org.openqa.selenium.testing.NoDriverAfterTest;
45-
import org.openqa.selenium.testing.NoDriverBeforeTest;
46-
import org.openqa.selenium.testing.NotYetImplemented;
47-
import org.openqa.selenium.testing.SwitchToTopAfterTest;
48-
49-
import java.time.Duration;
50-
import java.util.Set;
51-
5252
public class PageLoadingTest extends JUnit4TestBase {
5353

5454
private void initDriverWithLoadStrategy(String strategy) {
@@ -245,7 +245,9 @@ public void testShouldBeAbleToLoadAPageWithFramesetsAndWaitUntilAllFramesAreLoad
245245
@NeedsFreshDriver
246246
@Test
247247
@NotYetImplemented(value = HTMLUNIT,
248-
reason = "HtmlUnit: can't execute JavaScript before a page is loaded")
248+
reason = "HtmlUnit: can't execute JavaScript before a page is loaded")
249+
@NotYetImplemented(value = CHROME,
250+
reason = "https://bugs.chromium.org/p/chromedriver/issues/detail?id=4085")
249251
@Ignore(value = SAFARI, reason = "Hanging")
250252
public void testShouldDoNothingIfThereIsNothingToGoBackTo() {
251253
Set<String> currentWindowHandles = driver.getWindowHandles();

‎java/test/org/openqa/selenium/TypingTest.java

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,13 @@
1717

1818
package org.openqa.selenium;
1919

20+
import org.junit.Test;
21+
import org.openqa.selenium.support.ui.ExpectedConditions;
22+
import org.openqa.selenium.testing.Ignore;
23+
import org.openqa.selenium.testing.JUnit4TestBase;
24+
import org.openqa.selenium.testing.NotYetImplemented;
25+
import org.openqa.selenium.testing.drivers.Browser;
26+
2027
import static com.google.common.base.Joiner.on;
2128
import static org.assertj.core.api.Assertions.assertThat;
2229
import static org.assertj.core.api.Assertions.assertThatExceptionOfType;
@@ -27,13 +34,6 @@
2734
import static org.openqa.selenium.testing.drivers.Browser.IE;
2835
import static org.openqa.selenium.testing.drivers.Browser.SAFARI;
2936

30-
import org.junit.Test;
31-
import org.openqa.selenium.support.ui.ExpectedConditions;
32-
import org.openqa.selenium.testing.Ignore;
33-
import org.openqa.selenium.testing.JUnit4TestBase;
34-
import org.openqa.selenium.testing.NotYetImplemented;
35-
import org.openqa.selenium.testing.drivers.Browser;
36-
3737
public class TypingTest extends JUnit4TestBase {
3838

3939
private static void checkRecordedKeySequence(WebElement element, int expectedKeyCode) {
@@ -414,7 +414,6 @@ public void testDeleteAndBackspaceKeys() {
414414
}
415415

416416
@Test
417-
@NotYetImplemented(value = FIREFOX)
418417
public void testSpecialSpaceKeys() {
419418
driver.get(pages.javascriptPage);
420419

@@ -425,7 +424,6 @@ public void testSpecialSpaceKeys() {
425424
}
426425

427426
@Test
428-
@NotYetImplemented(value = FIREFOX)
429427
@NotYetImplemented(value = SAFARI, reason = "Enters dot instead of comma")
430428
public void testNumberPadKeys() {
431429
driver.get(pages.javascriptPage);

0 commit comments

Comments
 (0)