Skip to content

Commit 54312a8

Browse files
committed
[grid] A few semantic changes, no logical changes
[skip ci]
1 parent deeaa71 commit 54312a8

File tree

3 files changed

+18
-18
lines changed

3 files changed

+18
-18
lines changed

‎java/src/org/openqa/selenium/grid/distributor/local/LocalDistributor.java

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -125,7 +125,7 @@ public class LocalDistributor extends Distributor implements Closeable {
125125
private final GridModel model;
126126
private final Map<NodeId, Node> nodes;
127127

128-
private final ScheduledExecutorService sessionService =
128+
private final ScheduledExecutorService newSessionService =
129129
Executors.newSingleThreadScheduledExecutor(
130130
r -> {
131131
Thread thread = new Thread(r);
@@ -192,7 +192,7 @@ public LocalDistributor(
192192
// if sessionRequestRetryInterval is 0, we will schedule session creation every 10 millis
193193
long period = sessionRequestRetryInterval.isZero() ?
194194
10 : sessionRequestRetryInterval.toMillis();
195-
sessionService.scheduleAtFixedRate(
195+
newSessionService.scheduleAtFixedRate(
196196
newSessionRunnable,
197197
sessionRequestRetryInterval.toMillis(),
198198
period,
@@ -592,7 +592,7 @@ public void close() {
592592
LOG.info("Shutting down Distributor executor service");
593593
purgeDeadNodes.shutdown();
594594
hostChecker.shutdown();
595-
sessionService.shutdown();
595+
newSessionService.shutdown();
596596
}
597597

598598
private class NewSessionRunnable implements Runnable {

‎java/src/org/openqa/selenium/grid/log/LoggingFlags.java

Lines changed: 13 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -17,6 +17,15 @@
1717

1818
package org.openqa.selenium.grid.log;
1919

20+
import static org.openqa.selenium.grid.config.StandardGridRoles.ALL_ROLES;
21+
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_CONFIGURE_LOGGING;
22+
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_HTTP_LOGS;
23+
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_LOG_LEVEL;
24+
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_PLAIN_LOGS;
25+
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_STRUCTURED_LOGS;
26+
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_TRACING_ENABLED;
27+
import static org.openqa.selenium.grid.log.LoggingOptions.LOGGING_SECTION;
28+
2029
import com.google.auto.service.AutoService;
2130

2231
import com.beust.jcommander.Parameter;
@@ -27,15 +36,6 @@
2736

2837
import java.util.Set;
2938

30-
import static org.openqa.selenium.grid.config.StandardGridRoles.ALL_ROLES;
31-
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_CONFIGURE_LOGGING;
32-
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_HTTP_LOGS;
33-
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_LOG_LEVEL;
34-
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_PLAIN_LOGS;
35-
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_STRUCTURED_LOGS;
36-
import static org.openqa.selenium.grid.log.LoggingOptions.DEFAULT_TRACING_ENABLED;
37-
import static org.openqa.selenium.grid.log.LoggingOptions.LOGGING_SECTION;
38-
3939
@SuppressWarnings("FieldMayBeFinal")
4040
@AutoService(HasRoles.class)
4141
public class LoggingFlags implements HasRoles {
@@ -65,10 +65,10 @@ public class LoggingFlags implements HasRoles {
6565
private Boolean httpLogs = DEFAULT_HTTP_LOGS;
6666

6767
@Parameter(description = "File to write out logs. "
68-
+ "Ensure the file path is compatible with the operating system's file path.\n"
69-
+ "# Windows path example : \\\\path\\to\\file\\gridlog.log OR "
70-
+ "C:\\path\\path\\to\\file\\gridlog.log \n"
71-
+ "# Linux/Unix/MacOS path example : /path/to/file/gridlog.log \n"
68+
+ "Ensure the file path is compatible with the operating system's file path. "
69+
+ "Windows path example: \\\\path\\to\\file\\gridlog.log OR "
70+
+ "C:\\path\\path\\to\\file\\gridlog.log "
71+
+ "Linux/Unix/MacOS path example: /path/to/file/gridlog.log"
7272
, names = "--log", arity = 1)
7373
@ConfigValue(section = LOGGING_SECTION, name = "log-file", example = {"'\\\\path\\to\\file\\gridlog.log'",
7474
"'C:\\path\\path\\to\\file\\gridlog.log'",

‎java/src/org/openqa/selenium/grid/node/docker/DockerFlags.java

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -59,8 +59,8 @@ public class DockerFlags implements HasRoles {
5959

6060
@Parameter(
6161
names = {"--docker", "-D"},
62-
description = "Docker configs which map image name to stereotype capabilities (example " +
63-
"`-D selenium/standalone-firefox:latest '{\"browserName\": \"firefox\"}'`)",
62+
description = "Docker configs which map image name to stereotype capabilities (example: " +
63+
"-D selenium/standalone-firefox:latest '{\"browserName\": \"firefox\"}')",
6464
arity = 2,
6565
variableArity = true,
6666
splitter = NonSplittingSplitter.class)

0 commit comments

Comments
 (0)