Skip to content

Commit 466621d

Browse files
committed
[py] don't use websocket-port if user sets connect-existing (a4dc6e)
1 parent a4dc6ea commit 466621d

File tree

1 file changed

+2
-2
lines changed

1 file changed

+2
-2
lines changed

‎py/selenium/webdriver/firefox/service.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -19,7 +19,6 @@
1919

2020
from selenium.webdriver.common import (service, utils)
2121

22-
2322
DEFAULT_EXECUTABLE_PATH = "geckodriver"
2423

2524

@@ -53,7 +52,8 @@ def __init__(self, executable_path: str = DEFAULT_EXECUTABLE_PATH,
5352
self, executable_path, port=port, log_file=log_file, env=env)
5453
self.service_args = service_args or []
5554
# Set a port for CDP
56-
self.service_args.append("--websocket-port")
55+
if '--connect-existing' not in service_args:
56+
self.service_args.append("--websocket-port")
5757
self.service_args.append("%d" % utils.free_port())
5858
# Set the webdriver port
5959
self.service_args.append("--port")

0 commit comments

Comments
 (0)