Skip to content

Commit 2d36ea2

Browse files
committed
[grid] Matching webview2 browser name with EdgeDriverService
This is to support https://docs.microsoft.com/en-us/microsoft-edge/webview2/how-to/webdriver #9714
1 parent 001963b commit 2d36ea2

File tree

2 files changed

+16
-9
lines changed

2 files changed

+16
-9
lines changed

‎java/src/org/openqa/selenium/edge/EdgeDriverInfo.java

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,11 @@
1616
// under the License.
1717
package org.openqa.selenium.edge;
1818

19+
import static org.openqa.selenium.remote.Browser.EDGE;
20+
import static org.openqa.selenium.remote.CapabilityType.BROWSER_NAME;
21+
1922
import com.google.auto.service.AutoService;
23+
2024
import org.openqa.selenium.Capabilities;
2125
import org.openqa.selenium.ImmutableCapabilities;
2226
import org.openqa.selenium.SessionNotCreatedException;
@@ -25,12 +29,8 @@
2529
import org.openqa.selenium.WebDriverInfo;
2630
import org.openqa.selenium.chromium.ChromiumDriverInfo;
2731

28-
import java.util.Objects;
2932
import java.util.Optional;
3033

31-
import static org.openqa.selenium.remote.Browser.EDGE;
32-
import static org.openqa.selenium.remote.CapabilityType.BROWSER_NAME;
33-
3434
@AutoService(WebDriverInfo.class)
3535
public class EdgeDriverInfo extends ChromiumDriverInfo {
3636

@@ -46,7 +46,9 @@ public Capabilities getCanonicalCapabilities() {
4646

4747
@Override
4848
public boolean isSupporting(Capabilities capabilities) {
49+
//webview2 - support https://docs.microsoft.com/en-us/microsoft-edge/webview2/how-to/webdriver
4950
return EDGE.is(capabilities.getBrowserName())
51+
|| "webview2".equalsIgnoreCase(capabilities.getBrowserName())
5052
|| capabilities.getCapability("ms:edgeOptions") != null
5153
|| capabilities.getCapability("edgeOptions") != null;
5254
}

‎java/src/org/openqa/selenium/edge/EdgeDriverService.java

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -16,7 +16,12 @@
1616
// under the License.
1717
package org.openqa.selenium.edge;
1818

19+
import static java.util.Collections.unmodifiableList;
20+
import static java.util.Collections.unmodifiableMap;
21+
import static org.openqa.selenium.remote.Browser.EDGE;
22+
1923
import com.google.auto.service.AutoService;
24+
2025
import org.openqa.selenium.Capabilities;
2126
import org.openqa.selenium.WebDriverException;
2227
import org.openqa.selenium.remote.service.DriverService;
@@ -28,11 +33,6 @@
2833
import java.util.HashMap;
2934
import java.util.List;
3035
import java.util.Map;
31-
import java.util.Objects;
32-
33-
import static java.util.Collections.unmodifiableList;
34-
import static java.util.Collections.unmodifiableMap;
35-
import static org.openqa.selenium.remote.Browser.EDGE;
3636

3737
/**
3838
* Manages the life and death of the EdgeDriver (MicrosoftWebDriver or MSEdgeDriver).
@@ -125,6 +125,11 @@ public int score(Capabilities capabilities) {
125125
score++;
126126
}
127127

128+
//webview2 - support https://docs.microsoft.com/en-us/microsoft-edge/webview2/how-to/webdriver
129+
if ("webview2".equalsIgnoreCase(capabilities.getBrowserName())) {
130+
score++;
131+
}
132+
128133
if (capabilities.getCapability(EdgeOptions.CAPABILITY) != null) {
129134
score++;
130135
}

0 commit comments

Comments
 (0)