[rb] guard scroll tests from Firefox

Author: titusfortner

rb/spec/integration/selenium/webdriver/action_builder_spec.rb

@@ -176,6 +176,7 @@ module WebDriver
           driver.navigate.to url_for('javascriptPage.html')
           element = driver.find_element(id: 'doubleClickField')
 
+          sleep 0.5
           driver.action.double_click(element).perform
           expect(element.attribute(:value)).to eq('DoubleClicked')
         end
@@ -252,7 +253,7 @@ module WebDriver
           driver.navigate.to url_for('javascriptPage.html')
           element = driver.find_element(id: 'clickField')
           rect = element.rect
-          driver.action.move_to_location(rect.x, rect.y).click.perform
+          driver.action.move_to_location(rect.x.ceil, rect.y.ceil).click.perform
 
           expect(element.attribute(:value)).to eq('Clicked')
         end
@@ -269,7 +270,7 @@ def in_viewport?(element)
         driver.execute_script(in_viewport, element)
       end
 
-      describe '#scroll_to' do
+      describe '#scroll_to', only: {browser: %i[chrome edge]} do
         it 'scrolls to element' do
           driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
           iframe = driver.find_element(tag_name: 'iframe')
@@ -281,7 +282,7 @@ def in_viewport?(element)
         end
       end
 
-      describe '#scroll_from' do
+      describe '#scroll_from', only: {browser: %i[chrome edge]} do
         it 'scrolls from element by the provided amount' do
           driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
 
@@ -315,7 +316,7 @@ def in_viewport?(element)
         end
       end
 
-      describe '#scroll_by' do
+      describe '#scroll_by', only: {browser: %i[chrome edge]} do
         it 'scrolls by amount provided' do
           driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame_out_of_view.html')
 
@@ -326,25 +327,25 @@ def in_viewport?(element)
 
           expect(in_viewport?(footer)).to eq true
         end
-      end
 
-      it 'scrolls by amount provided from provided origin' do
-        driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame.html')
+        it 'scrolls by amount provided from provided origin' do
+          driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame.html')
 
-        iframe = driver.find_element(tag_name: 'iframe')
-        driver.action.scroll_by(0, 200, origin_x: 10, origin_y: 10).perform
+          iframe = driver.find_element(tag_name: 'iframe')
+          driver.action.scroll_by(0, 200, origin_x: 10, origin_y: 10).perform
 
-        driver.switch_to.frame(iframe)
-        checkbox = driver.find_element(name: 'scroll_checkbox')
-        expect(in_viewport?(checkbox)).to eq true
-      end
+          driver.switch_to.frame(iframe)
+          checkbox = driver.find_element(name: 'scroll_checkbox')
+          expect(in_viewport?(checkbox)).to eq true
+        end
 
-      it 'throws MoveTargetOutOfBoundsError when origin offset is out of viewport' do
-        driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame.html')
+        it 'throws MoveTargetOutOfBoundsError when origin offset is out of viewport' do
+          driver.navigate.to url_for('scrolling_tests/frame_with_nested_scrolling_frame.html')
 
-        expect {
-          driver.action.scroll_by(0, 200, origin_x: -10, origin_y: -10).perform
-        }.to raise_error(Error::MoveTargetOutOfBoundsError)
+          expect {
+            driver.action.scroll_by(0, 200, origin_x: -10, origin_y: -10).perform
+          }.to raise_error(Error::MoveTargetOutOfBoundsError)
+        end
       end
     end # ActionBuilder
   end # WebDriver

rb/spec/unit/selenium/webdriver/common/interactions/pointer_input_spec.rb

@@ -74,7 +74,7 @@ module Interactions
 
         describe '#create_pointer_down' do
           it 'executes #add_action with created interaction' do
-            allow(PointerPress).to receive(:new).with(pointer, :down, :left).and_return(interaction)
+            allow(PointerPress).to receive(:new).with(pointer, :down, :left, {}).and_return(interaction)
             allow(pointer).to receive(:add_action).and_call_original
 
             pointer.create_pointer_down(:left)
@@ -85,7 +85,7 @@ module Interactions
 
         describe '#create_pointer_up' do
           it 'executes #add_action with created interaction' do
-            allow(PointerPress).to receive(:new).with(pointer, :up, :left).and_return(interaction)
+            allow(PointerPress).to receive(:new).with(pointer, :up, :left, {}).and_return(interaction)
             allow(pointer).to receive(:add_action).and_call_original
 
             pointer.create_pointer_up(:left)