Skip to content

Commit 1990a43

Browse files
committed
[java] Remove connection timeout setter
Since the AsyncHttpClient is initialized using a static block and that uses the default client config values, any newly set value of connection timeout is never used.
1 parent 48848de commit 1990a43

File tree

2 files changed

+0
-11
lines changed

2 files changed

+0
-11
lines changed

‎java/src/org/openqa/selenium/remote/http/ClientConfig.java

Lines changed: 0 additions & 10 deletions
Original file line numberDiff line numberDiff line change
@@ -93,16 +93,6 @@ public URL baseUrl() {
9393
}
9494
}
9595

96-
public ClientConfig connectionTimeout(Duration timeout) {
97-
return new ClientConfig(
98-
baseUri,
99-
Require.nonNull("Connection timeout", timeout),
100-
readTimeout,
101-
filters,
102-
proxy,
103-
credentials);
104-
}
105-
10696
public Duration connectionTimeout() {
10797
return connectionTimeout;
10898
}

‎java/test/org/openqa/selenium/remote/RemoteWebDriverBuilderTest.java

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -310,7 +310,6 @@ public void shouldSetRemoteHostUriOnClientConfigIfSet() {
310310
@Test
311311
public void shouldThrowErrorIfCustomConfigIfSetForLocalDriver() {
312312
ClientConfig config = ClientConfig.defaultConfig()
313-
.connectionTimeout(Duration.ofMinutes(5))
314313
.readTimeout(Duration.ofMinutes(4));
315314

316315
RemoteWebDriverBuilder builder = RemoteWebDriver.builder()

0 commit comments

Comments
 (0)