Skip to content

pullrequests Search Results · repo:magento/magento-coding-standard language:PHP is:public

Filter by

322 results
 (136 ms)

322 results

inmagento/magento-coding-standard (press backspace or delete to remove)

magento/magento-coding-standard
Small cleanup, removed duplicated keys from array

proc_open = null, is already defined in the same array on line 38, it makes no sense to keep both around. Found with phpstan (while running it from inside magento core codebase): $ ./vendor/bin/phpstan ...
  • hostep
  • Opened 
    on Apr 19
  • #495

magento/magento-coding-standard
Add support for Rector 2.x

Fixes #493
  • fooman
  • 1
  • Opened 
    on Mar 13
  • #494

magento/magento-coding-standard
Require a strict_types declaration

Fixes #33 The current composer.json file requires version 3.6.1 or better of PHP_CodeSniffer. That version and versions up to 3.7.2 only check that there is a declaration, but not if the declaration is ...
Partner: Youwe
partners-contribution
Progress: approved
  • fredden
  • 1
  • Opened 
    on Sep 27, 2024
  • #488

magento/magento-coding-standard
Update supported PHP versions to match Magento

Version 2.4.7-p2 (which is the latest at time of writing) supports PHP versions 8.1.x and 8.2.x and 8.3.x. This change updates the PHPCompatibility configuration to scan for these versions. https://github.com/magento/magento2/blob/2.4.7-p2/composer.json#L21 ...
Partner: Youwe
partners-contribution
Progress: approved
  • fredden
  • 1
  • Opened 
    on Sep 10, 2024
  • #487

magento/magento-coding-standard
Resolve issues with regex include and exclude patterns in Magento 2 ruleset.xml

See https://github.com/magento/magento-coding-standard/issues/485 for a detailed description of the issue. These fixes makes the following assumptions and these will need to be verified by someone who ...
Progress: approved
  • gwharton
  • 1
  • Opened 
    on Aug 29, 2024
  • #486

magento/magento-coding-standard
Fix Class Property DocBlock sniff for union/intersection types

Since PHP_CodeSniffer 3.7.0, there s a separate token T_TYPE_INTERSECTION for the type-intersection specifier, instead of using the same T_BITWISE_AND token for both type intersections and the bitwise ...
  • CRC-Mismatch
  • 4
  • Opened 
    on Jul 31, 2024
  • #483

magento/magento-coding-standard
AC-12039: Exclude xml files in "Generic.Files.LineLength" rule in Static Test ruleset

https://jira.corp.adobe.com/browse/AC-12039
Progress: ready for review
  • yaroslavGoncharuk
  • Opened 
    on May 29, 2024
  • #480

magento/magento-coding-standard
Avoid false positive with 'use function ...' lines

Fixes #477
Partner: Youwe
partners-contribution
Progress: ready for review
  • fredden
  • Opened 
    on Mar 25, 2024
  • #478

magento/magento-coding-standard
Member variables and methods should not require DocBlock when properly typed

https://wiki.corp.adobe.com/pages/viewpage.action?spaceKey=MC title=Proposal+to+change+magento-coding-standard+to+not+require+DocBlock+when+parameters+defined
Progress: review
  • JacobBrownAustin
  • 20
  • Opened 
    on Dec 14, 2023
  • #476

magento/magento-coding-standard
Replace dependency on abandoned PHP_CodeSniffer tool

Fixes #474
  • JosephLeedy
  • 3
  • Opened 
    on Dec 1, 2023
  • #475