Add ":" to split function within getName. #33
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
|
Please remove the whitespace only changes. Although we agree with stripping them we don't want whitespace only changes applied in other patches, it makes the history unreadable (as well as the diff) and makes merges much harder. With respect to the content of the change what is your use case? It looks like you're changing the pre-groovy legacy support behavior for name lookup. here |
|
We're looking to use getName() to extract a valid rosgraph name in both the legacy (package_name/plugin_name) and the modern (package_namespace::plugin_class) style. |
mikeodr
force-pushed
the
getName-split-fix
branch
from
21b7352 to
012eaf5
Compare
Author
|
Whitespace removed. |
getName split wasn't supporting `::` as the delimiter for the package name and the plugin name.
mikeodr
force-pushed
the
getName-split-fix
branch
from
012eaf5 to
90af041
Compare
Member
|
LGTM. Thanks @mikeodr ! |
esteve
added a commit
that referenced
this pull request
Dec 8, 2015
Add ":" to split function within getName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
getName split wasn't supporting
::as the delimiter for the package name andthe plugin name.