Change max_cost default to 254 (#5256) (#5258)

(cherry picked from commit 279e17e)

Signed-off-by: Tony Najjar <tony.najjar.1997@gmail.com>
Co-authored-by: Tony Najjar <tony.najjar.1997@gmail.com>

Author: mergify[bot]

nav2_behavior_tree/plugins/condition/is_path_valid_condition.cpp

@@ -24,7 +24,7 @@ IsPathValidCondition::IsPathValidCondition(
   const std::string & condition_name,
   const BT::NodeConfiguration & conf)
 : BT::ConditionNode(condition_name, conf),
-  max_cost_(253), consider_unknown_as_obstacle_(false)
+  max_cost_(254), consider_unknown_as_obstacle_(false)
 {
   node_ = config().blackboard->get<rclcpp::Node::SharedPtr>("node");
   client_ = std::make_shared<nav2_util::ServiceClient<nav2_msgs::srv::IsPathValid>>("is_path_valid",

nav2_msgs/srv/IsPathValid.srv

@@ -1,7 +1,7 @@
 #Determine if the current path is still valid
 
 nav_msgs/Path path
-uint8 max_cost 253
+uint8 max_cost 254
 bool consider_unknown_as_obstacle false
 ---
 bool is_valid