Use new handles API in ros2_controllers to fix deprecation warnings #1566
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
requested review from
DasRoteSkelett,
VX792,
arne48,
christophfroehlich,
homalozoa,
mhubii and
saikishor
Member
christophfroehlich
left a comment
christophfroehlich
left a comment
There was a problem hiding this comment.
Looks fine, thanks!
Contributor
Author
@christophfroehlich hi, one question - I have made progress on other controllers as well locally on my system. Can I push these changes into this PR as well (will update description), or should I wait for more reviews on current submitted PR ? |
Member
saikishor
reviewed
Mar 5, 2025
Member
saikishor
left a comment
saikishor
left a comment
There was a problem hiding this comment.
The changes already look good to me. I just forgot to comment.
@kumar-sanjeeev yes, please proceed with other packages as well
…sensor_broadcaster tests
…l, without failures
Contributor
Author
|
@saikishor and @christophfroehlich , one question, would you like me to complete all the controller packages first, and then you would review them of all together? Or would you prefer to first provide feedback on the commits that have already been pushed in this PR? |
Member
|
apply the changes to all of them please |
Member
|
Yes please |
...r_controller/include/parallel_gripper_controller/parallel_gripper_action_controller_impl.hpp
Outdated
Show resolved
Hide resolved
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
saikishor
reviewed
Jul 21, 2025
tricycle_steering_controller/src/tricycle_steering_controller.cpp
Outdated
Show resolved
Hide resolved
christophfroehlich
approved these changes
Jul 22, 2025
christophfroehlich
merged commit 76c07f9
into
ros-controls:master
19 of 26 checks passed
Contributor
Author
|
@christophfroehlich, @saikishor, thank you both for reviewing this PR, and 🙌 @christophfroehlich for taking care code review suggestions from @saikishor. |
Member
Thanks to you for all the efforts @kumar-sanjeeev :) |
mergify bot
pushed a commit
that referenced
this pull request
Sep 26, 2025
…1566) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Co-authored-by: ska <sanjeev.kumar@ipa.fraunhofer.de> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com> (cherry picked from commit 76c07f9) # Conflicts: # forward_command_controller/src/forward_controllers_base.cpp # joint_trajectory_controller/src/joint_trajectory_controller.cpp # parallel_gripper_controller/include/parallel_gripper_controller/parallel_gripper_action_controller_impl.hpp # pid_controller/test/test_pid_controller.cpp # pid_controller/test/test_pid_controller_dual_interface.cpp # steering_controllers_library/src/steering_controllers_library.cpp # steering_controllers_library/test/test_steering_controllers_library.cpp
19 tasks
saikishor
added a commit
that referenced
this pull request
Sep 27, 2025
…1566) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Co-authored-by: ska <sanjeev.kumar@ipa.fraunhofer.de> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
saikishor
added a commit
that referenced
this pull request
Sep 27, 2025
…1566) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Co-authored-by: ska <sanjeev.kumar@ipa.fraunhofer.de> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
saikishor
added a commit
that referenced
this pull request
Sep 27, 2025
…1566) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Co-authored-by: ska <sanjeev.kumar@ipa.fraunhofer.de> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
saikishor
added a commit
that referenced
this pull request
Sep 27, 2025
…1566) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Co-authored-by: ska <sanjeev.kumar@ipa.fraunhofer.de> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
saikishor
added a commit
that referenced
this pull request
Sep 27, 2025
…1566) Co-authored-by: Christoph Fröhlich <christophfroehlich@users.noreply.github.com> Co-authored-by: ska <sanjeev.kumar@ipa.fraunhofer.de> Co-authored-by: Christoph Froehlich <christoph.froehlich@ait.ac.at> Co-authored-by: Sai Kishor Kothakota <saisastra3@gmail.com>
christophfroehlich
pushed a commit
that referenced
this pull request
Oct 2, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR applies the new API changes in the handles of ros2_control in following controllers in same fashion as #1565: