Skip to content

Commit 4616b51

Browse files
committed
Makefile: remove bashism
"pushd/popd" are not part of POSIX and not supported by dash, the default shell on Debian and Ubuntu. This causes the following command to fail: $ make cli WEBROOT=/nvme/gopath/src/k8s.io/website K8SROOT=/nvme/gopath/src/k8s.io/kubernetes K8SRELEASE=1.23.0-beta.0 sudo rm -f main sudo rm -rf /nvme/gopath/src/sigs.k8s.io/reference-docs/gen-kubectldocs/generators/includes sudo rm -rf /nvme/gopath/src/sigs.k8s.io/reference-docs/gen-kubectldocs/generators/build sudo rm -rf /nvme/gopath/src/sigs.k8s.io/reference-docs/gen-kubectldocs/generators/manifest.json pushd gen-kubectldocs && go mod download && go run main.go --kubernetes-version v1_23 && popd /bin/sh: 1: pushd: not found Changing back to the original directory is unnecessary here because each make command runs in its own shell.
1 parent 0c18683 commit 4616b51

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

‎Makefile‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -43,7 +43,7 @@ cleancli:
4343
sudo rm -rf $(shell pwd)/gen-kubectldocs/generators/manifest.json
4444

4545
cli: cleancli
46-
pushd gen-kubectldocs && go mod download && go run main.go --kubernetes-version v$(K8SRELEASEDIR) && popd
46+
cd gen-kubectldocs && go mod download && go run main.go --kubernetes-version v$(K8SRELEASEDIR)
4747
mkdir -p $(CLISRC)
4848
docker run -v $(shell pwd)/gen-kubectldocs/generators/includes:/source -v $(shell pwd)/gen-kubectldocs/generators/build:/build -v $(shell pwd)/gen-kubectldocs/generators/:/manifest brianpursley/brodocs:latest
4949

0 commit comments

Comments
 (0)