-
-
Notifications
You must be signed in to change notification settings - Fork 1.1k
Bugfix/issue 7371 #7447
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Bugfix/issue 7371 #7447
Conversation
Changed Firestore replication, reads events from onSnapshot
|
Built RxDB with this pull request in my application, seems to resolve issue with needing to call reSync() for updates & also fixes no-updates for documents moving outside of replication scope |
|
Hi @calvinturbo |
reSync() is needed, because Firestore does not provide information about what data is changed, only that the document has changed or removed
Doc in test was only updating data in Firestore DB but not modifying serverTimestamp causing a failed test when using reSync()
|
Test "two collections" fails for some reason. It returns 5 documents instead of the 10 documents added. Tried all kinds of things but didn't get it working. Even when putting this in the test itself: it still only returns 5 documents via the Firestore onSnapshot after adding the 10 documents via RxDB. |
This PR contains:
Describe the problem you have without this PR
Check #7371
Todos