Cache feature resolution at the namespace level instead of individual objects to avoid any O(n^2) scaling

Author: mkruskal-google

index.d.ts

@@ -750,6 +750,9 @@ export abstract class NamespaceBase extends ReflectionObject {
     /** Nested objects by name. */
     public nested?: { [k: string]: ReflectionObject };
 
+    /** Whether or not objects contained in this namespace need feature resolution. */
+    protected _needsRecursiveFeatureResolution: boolean;
+
     /** Nested objects of this namespace as an array for iteration. */
     public readonly nestedArray: ReflectionObject[];
 
@@ -909,9 +912,6 @@ export abstract class ReflectionObject {
     /** Resolved Features. */
     public _features: object;
 
-    /** Whether or not features have been resolved. */
-    public _featuresResolved: boolean;
-
     /** Parent namespace. */
     public parent: (Namespace|null);
 

src/namespace.js

@@ -117,17 +117,23 @@ function Namespace(name, options) {
      * @private
      */
     this._lookupCache = {};
+
+    /**
+     * Whether or not objects contained in this namespace need feature resolution.
+     * @type {boolean}
+     * @protected
+     */
+    this._needsRecursiveFeatureResolution = true;
 }
 
 function clearCache(namespace) {
     namespace._nestedArray = null;
     namespace._lookupCache = {};
 
     // Also clear parent caches, since they include nested lookups.
-    var parent = namespace.parent;
-    while(parent) {
+    var parent = namespace;
+    while(parent = parent.parent) {
         parent._lookupCache = {};
-        parent = parent.parent;
     }
     return namespace;
 }
@@ -266,6 +272,14 @@ Namespace.prototype.add = function add(object) {
         }
     }
 
+    this._needsRecursiveFeatureResolution = true;
+
+    // Also clear parent caches, since they need to recurse down.
+    var parent = this;
+    while(parent = parent.parent) {
+        parent._needsRecursiveFeatureResolution = true;
+    }
+
     object.onAdd(this);
     return clearCache(this);
 };
@@ -341,6 +355,9 @@ Namespace.prototype.resolveAll = function resolveAll() {
  * @override
  */
 Namespace.prototype._resolveFeaturesRecursive = function _resolveFeaturesRecursive(edition) {
+    if (!this._needsRecursiveFeatureResolution) return this;
+    this._needsRecursiveFeatureResolution = false;
+
     edition = this._edition || edition;
 
     ReflectionObject.prototype._resolveFeaturesRecursive.call(this, edition);

src/object.js

@@ -67,12 +67,6 @@ function ReflectionObject(name, options) {
      */
     this._features = {};
 
-    /**
-     * Whether or not features have been resolved.
-     * @type {boolean}
-     */
-    this._featuresResolved = false;
-
     /**
      * Parent namespace.
      * @type {Namespace|null}
@@ -198,10 +192,6 @@ ReflectionObject.prototype._resolveFeaturesRecursive = function _resolveFeatures
  * @returns {undefined}
  */
 ReflectionObject.prototype._resolveFeatures = function _resolveFeatures(edition) {
-    if (this._featuresResolved) {
-        return;
-    }
-
     var defaults = {};
 
     /* istanbul ignore if */
@@ -225,7 +215,6 @@ ReflectionObject.prototype._resolveFeatures = function _resolveFeatures(edition)
             throw new Error("Unknown edition: " + edition);
         }
         this._features = Object.assign(defaults, protoFeatures || {});
-        this._featuresResolved = true;
         return;
     }
 
@@ -247,7 +236,6 @@ ReflectionObject.prototype._resolveFeatures = function _resolveFeatures(edition)
         // Sister fields should have the same features as their extensions.
         this.extensionField._features = this._features;
     }
-    this._featuresResolved = true;
 };
 
 /**

src/service.js

@@ -121,6 +121,8 @@ Service.prototype.resolveAll = function resolveAll() {
  * @override
  */
 Service.prototype._resolveFeaturesRecursive = function _resolveFeaturesRecursive(edition) {
+    if (!this._needsRecursiveFeatureResolution) return this;
+
     edition = this._edition || edition;
 
     Namespace.prototype._resolveFeaturesRecursive.call(this, edition);

src/type.js

@@ -317,6 +317,8 @@ Type.prototype.resolveAll = function resolveAll() {
  * @override
  */
 Type.prototype._resolveFeaturesRecursive = function _resolveFeaturesRecursive(edition) {
+    if (!this._needsRecursiveFeatureResolution) return this;
+
     edition = this._edition || edition;
 
     Namespace.prototype._resolveFeaturesRecursive.call(this, edition);