-
Notifications
You must be signed in to change notification settings - Fork 5.5k
feat: Add cluster tag config and UI #26485
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Reviewer's GuideThis PR introduces a new clusterTag configuration property, wires it through the cluster stats REST endpoints, extends the ClusterStats model (with serialization tests), and enhances the UI to fetch and display the cluster tag badge in the navbar with updated responsive styling. Sequence diagram for UI fetching and displaying clusterTagsequenceDiagram
participant UI
participant Server
UI->>Server: GET /v1/cluster
Server-->>UI: { clusterTag }
UI->>UI: setClusterTag(clusterTag)
UI->>UI: Render clusterTag badge in navbar
ER diagram for ClusterStats model changeserDiagram
CLUSTER_STATS {
string runningQueries
string blockedQueries
string queuedQueries
long totalInputRows
long totalInputBytes
long totalCpuTimeSecs
long adjustedQueueSize
string clusterTag
}
SERVER_CONFIG {
string clusterTag
}
SERVER_CONFIG ||--o| CLUSTER_STATS : provides
Class diagram for updated ClusterStats and ServerConfig classesclassDiagram
class ServerConfig {
+Duration clusterStatsExpirationDuration
+boolean nestedDataSerializationEnabled
+Duration clusterResourceGroupStateInfoExpirationDuration
+String clusterTag
+boolean isResourceManager()
+String getClusterTag()
+ServerConfig setClusterTag(String clusterTag)
}
class ClusterStats {
+List runningQueries
+List blockedQueries
+List queuedQueries
+long totalInputRows
+long totalInputBytes
+long totalCpuTimeSecs
+long adjustedQueueSize
+String clusterTag
+getClusterTag()
}
ServerConfig <|-- ClusterStats
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
|
@tdcmeehan WIP as a step 1, lemme know if this is in line with what you were envisioning |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! (docs)
Pull branch, local doc build, looks good. Thanks!
This is almost exactly what I had in mind! |
Description
Motivation and Context
Impact
With and without a cluster tag configured:
Test Plan
Contributor checklist
Release Notes
Please follow release notes guidelines and fill in the release notes below.
If release note is NOT required, use: