Move shared link form to modal #5849
Open
+737
−341
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- As a preliminary step for enabling adding a pinned segment to a shared link, the functionality to add or edit a shared link is being moved to a modal. - Minor UI improvements, such as update the style of the edit and delete buttons.
sanne-san
force-pushed
the
sanne-shared-link-modal
branch
from
037b7ff to
43acdb0
Compare
- Add shared_link_settings_test.exs for LiveView interactions (deletion, errors) - Add shared_link_settings/form_test.exs for modal form testing (create, edit, validation) - Update controller tests: remove deleted actions, update visibility test
|
|
Relied heavily on the pattern used for adding a goal, please review thoroughly |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Tests
Dark mode