Skip to content

planner: maintain a map of column indices by name in DataSource #64204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 4 commits into
base: master
Choose a base branch
from
+112 −12
Open

planner: maintain a map of column indices by name in DataSource #64204

Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
5a57bc0
planner: maintain a map of column indices by name in DataSource
henrybw Oct 13, 2025
1078e5e
don't shadow the loop induction variable
henrybw Oct 31, 2025
21d6381
`GetColIdxsByName` -> `GetColIdxMapping`
henrybw Oct 31, 2025
eb145bd
`TestColIdxsByName` -> `TestColIdxMapping`
henrybw Oct 31, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
don't shadow the loop induction variable
  • Loading branch information
@henrybw
henrybw committed Oct 31, 2025
commit 1078e5ecfccacd7e1aa2d59bd0f673bb3575d2bc
4 changes: 2 additions & 2 deletions pkg/planner/core/operator/logicalop/logical_datasource.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -199,8 +199,8 @@ func (ds *DataSource) PruneColumns(parentUsedCols []*expression.Column) (base.Lo
continue
}
delete(ds.ColIdxsByName, ds.Columns[i].Name.L)
for i := i + 1; i < len(ds.Columns); i++ {
ds.ColIdxsByName[ds.Columns[i].Name.L] = i - 1
for j := i + 1; j < len(ds.Columns); j++ {
ds.ColIdxsByName[ds.Columns[j].Name.L] = j - 1
}
// TODO: investigate why we cannot use slices.Delete for these two:
ds.Schema().Columns = append(ds.Schema().Columns[:i], ds.Schema().Columns[i+1:]...)
Expand Down