Skip to content

pkg/parser/ast: (Fix) Propagate error correctly #64184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
+12 −4
Open

pkg/parser/ast: (Fix) Propagate error correctly #64184

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 12 additions & 4 deletions pkg/parser/ast/dml.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3379,23 +3379,29 @@ func (n *ShowStmt) Restore(ctx *format.RestoreCtx) error {
ctx.WritePlainf("%d", *n.ImportJobID)
} else {
ctx.WriteKeyWord("IMPORT JOBS")
restoreShowLikeOrWhereOpt()
if err := restoreShowLikeOrWhereOpt(); err != nil {
return err
}
}
case ShowImportGroups:
if n.ShowGroupKey != "" {
ctx.WriteKeyWord("IMPORT GROUP ")
ctx.WriteString(n.ShowGroupKey)
} else {
ctx.WriteKeyWord("IMPORT GROUPS")
restoreShowLikeOrWhereOpt()
if err := restoreShowLikeOrWhereOpt(); err != nil {
return err
}
}
case ShowDistributionJobs:
if n.DistributionJobID != nil {
ctx.WriteKeyWord("DISTRIBUTION JOB ")
ctx.WritePlainf("%d", *n.DistributionJobID)
} else {
ctx.WriteKeyWord("DISTRIBUTION JOBS")
restoreShowLikeOrWhereOpt()
if err := restoreShowLikeOrWhereOpt(); err != nil {
return err
}
}
// ShowTargetFilterable
default:
Expand Down Expand Up @@ -3522,7 +3528,9 @@ func (n *ShowStmt) Restore(ctx *format.RestoreCtx) error {
default:
return errors.New("Unknown ShowStmt type")
}
restoreShowLikeOrWhereOpt()
if err := restoreShowLikeOrWhereOpt(); err != nil {
return err
}
}
return nil
}
Expand Down