Skip to content

expression: improve assertion to fix flaky test #64177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
+10 −4
Open

expression: improve assertion to fix flaky test #64177

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fc0d98f
expression: improve assertion to fix flaky test
hawkingrei Oct 29, 2025
13994cc
expression: improve assertion to fix flaky test
hawkingrei Oct 29, 2025
File filter

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions pkg/expression/scalar_function.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,19 +392,25 @@ func (sf *ScalarFunction) Equal(ctx EvalContext, e Expression) bool {
}
if sf.hashcode != nil && fun.hashcode != nil {
if intest.InTest {
assertCheckHashCode(sf)
assertCheckHashCode(fun)
copyhashcode := reHashCodeForTest(sf)
copyfunhashcode := reHashCodeForTest(fun)
intest.Assert(bytes.Equal(sf.hashcode, fun.hashcode) == bytes.Equal(copyfunhashcode, copyhashcode),
"HashCode should be stable and consistent")
}
return bytes.Equal(sf.hashcode, fun.hashcode)
}
return sf.Function.equal(ctx, fun.Function)
}

func assertCheckHashCode(sf *ScalarFunction) {
intest.Assert(intest.InTest)
func reHashCodeForTest(sf *ScalarFunction) (origin []byte) {
copyhashcode := make([]byte, len(sf.hashcode))
copy(copyhashcode, sf.hashcode)
ReHashCode(sf)
return copyhashcode
}
func assertCheckHashCode(sf *ScalarFunction) {
intest.Assert(intest.InTest)
copyhashcode := reHashCodeForTest(sf)
intest.Assert(bytes.Equal(sf.hashcode, copyhashcode), "HashCode should not change after ReHashCode is called")
}

Expand Down