Skip to content

Conversation

@tangenta
Copy link
Contributor

@tangenta tangenta commented Apr 17, 2025

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Update rebase auto id warning message.

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot bot added release-note-none Denotes a PR that doesn't merit a release note. do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2025
@tiprow
Copy link

tiprow bot commented Apr 17, 2025

Hi @tangenta. Thanks for your PR.

PRs from untrusted users cannot be marked as trusted with /ok-to-test in this repo meaning untrusted PR authors can never trigger tests themselves. Collaborators can still trigger tests on the PR using /test all.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@tangenta tangenta added the skip-issue-check Indicates that a PR no need to check linked issue. label Apr 17, 2025
@codecov
Copy link

codecov bot commented Apr 17, 2025

Codecov Report

❌ Patch coverage is 78.57143% with 3 lines in your changes missing coverage. Please review.
✅ Project coverage is 78.5724%. Comparing base (2c103b4) to head (86ec125).
⚠️ Report is 993 commits behind head on master.

Additional details and impacted files
@@               Coverage Diff                @@
##             master     #60616        +/-   ##
================================================
+ Coverage   73.0851%   78.5724%   +5.4872%     
================================================
  Files          1715       1898       +183     
  Lines        475095     582217    +107122     
================================================
+ Hits         347224     457462    +110238     
+ Misses       106494     101144      -5350     
- Partials      21377      23611      +2234     
Flag Coverage Δ
integration 48.7375% <57.1428%> (?)
unit 77.2843% <42.8571%> (+4.9709%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling 53.2371% <ø> (+0.5817%) ⬆️
parser ∅ <ø> (∅)
br 62.3607% <ø> (+15.1002%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
Signed-off-by: tangenta <tangenta@126.com>
@ti-chi-bot ti-chi-bot bot added size/S Denotes a PR that changes 10-29 lines, ignoring generated files. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 17, 2025
Copy link
Contributor

@lance6716 lance6716 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

need to check if user doc or something need to be updated

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 29, 2025

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: lance6716, zimulala
Once this PR has been reviewed and has the lgtm label, please ask for approval from tangenta, ensuring that each of them provides their approval before proceeding. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added lgtm and removed needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Apr 29, 2025
@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 29, 2025

[LGTM Timeline notifier]

Timeline:

  • 2025-04-18 02:52:57.35287937 +0000 UTC m=+3002471.037115458: ☑️ agreed by zimulala.
  • 2025-04-29 03:07:22.267571775 +0000 UTC m=+929786.079362154: ☑️ agreed by lance6716.
@lance6716
Copy link
Contributor

/retest

@tangenta you can /approve your own PR

@tiprow
Copy link

tiprow bot commented Apr 29, 2025

@lance6716: Cannot trigger testing until a trusted user reviews the PR and leaves an /ok-to-test message.

In response to this:

/retest

@tangenta you can /approve your own PR

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Apr 29, 2025

@tangenta: The following test failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
idc-jenkins-ci-tidb/mysql-test 86ec125 link true /test mysql-test

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

@lance6716
Copy link
Contributor

mysql-test needs to be updated @tangenta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

lgtm release-note-none Denotes a PR that doesn't merit a release note. size/S Denotes a PR that changes 10-29 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

3 participants