Skip to content

Conversation

@hawkingrei
Copy link
Member

@hawkingrei hawkingrei commented Sep 5, 2024

What problem does this PR solve?

Issue Number: close #xxx

Problem Summary:

What changed and how does it work?

Check List

Tests

  • Unit test
  • Integration test
  • Manual test (add detailed scripts or steps below)
  • No need to test
    • I checked and no code files have been changed.

Side effects

  • Performance regression: Consumes more CPU
  • Performance regression: Consumes more Memory
  • Breaking backward compatibility

Documentation

  • Affects user behaviors
  • Contains syntax changes
  • Contains variable changes
  • Contains experimental features
  • Changes MySQL compatibility

Release note

Please refer to Release Notes Language Style Guide to write a quality release note.

None
Signed-off-by: Weizhen Wang <wangweizhen@pingcap.com>
@ti-chi-bot ti-chi-bot bot added do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2024
@hawkingrei hawkingrei added skip-issue-check Indicates that a PR no need to check linked issue. and removed size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Sep 5, 2024
@ti-chi-bot ti-chi-bot bot added size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. and removed do-not-merge/needs-linked-issue do-not-merge/needs-tests-checked labels Sep 5, 2024
@codecov
Copy link

codecov bot commented Sep 5, 2024

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 56.0876%. Comparing base (fef43c5) to head (3305249).
⚠️ Report is 2411 commits behind head on master.

Additional details and impacted files
@@                Coverage Diff                @@
##             master     #55876         +/-   ##
=================================================
- Coverage   72.8403%   56.0876%   -16.7527%     
=================================================
  Files          1599       1724        +125     
  Lines        444670     620151     +175481     
=================================================
+ Hits         323899     347828      +23929     
- Misses       100835     248612     +147777     
- Partials      19936      23711       +3775     
Flag Coverage Δ
integration 49.5862% <ø> (?)
unit 72.6506% <ø> (+0.0583%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Components Coverage Δ
dumpling ∅ <ø> (∅)
parser ∅ <ø> (∅)
br 53.4879% <ø> (+6.9902%) ⬆️
🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2024

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: lance6716

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@ti-chi-bot ti-chi-bot bot added approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. labels Sep 13, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 13, 2024

[LGTM Timeline notifier]

Timeline:

  • 2024-09-13 06:39:54.933930555 +0000 UTC m=+597664.674354486: ☑️ agreed by lance6716.
@ti-chi-bot ti-chi-bot bot added the needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. label Sep 28, 2024
@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 28, 2024

PR needs rebase.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@ti-chi-bot
Copy link

ti-chi-bot bot commented Sep 26, 2025

@hawkingrei: The following tests failed, say /retest to rerun all failed tests or /retest-required to rerun all mandatory failed tests:

Test name Commit Details Required Rerun command
pull-integration-e2e-test 3305249 link true /test pull-integration-e2e-test
pull-integration-realcluster-test-next-gen 3305249 link true /test pull-integration-realcluster-test-next-gen
pull-unit-test-next-gen 3305249 link true /test pull-unit-test-next-gen

Full PR test history. Your PR dashboard.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. I understand the commands that are listed here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

approved needs-1-more-lgtm Indicates a PR needs 1 more LGTM. needs-rebase Indicates a PR cannot be merged because it has merge conflicts with HEAD. release-note-none Denotes a PR that doesn't merit a release note. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. skip-issue-check Indicates that a PR no need to check linked issue.

2 participants