-
Notifications
You must be signed in to change notification settings - Fork 200
6004: Should add tenuring summary to the GC visualization #679
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into |
|
@aymane-harmaz This change now passes all automated pre-integration checks. ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details. After integration, the commit message for the final commit will be: You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed. At the time when this comment was updated there had been no new commits pushed to the As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well. ➡️ To flag this PR as ready for integration with the above commit message, type |
Webrevs
|
|
Looks good Aymane! Do you also handle the case where the event is off, so that there aren't any tenuring distribution events available at all? |
| GarbageCollectionsPage_PAUSE_PHASES_TITLE=Pause Phases | ||
| GarbageCollectionsPage_TENURING_DISTRIBUTION_TITLE=Tenuring Distribution | ||
| GarbageCollectionsPage_TENURING_DISTRIBUTION_NO_SELECTION_MESSAGE=No valid Selection | ||
| GarbageCollectionsPage_TENURING_DISTRIBUTION_MULTI_SELECTION_MESSAGE=Distribution is shown for a single GC cycle |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Perhaps this can be more specific? "Multiple GC cycles selected. Distribution is only shown for a single GC."

This change adds a new tab to display the tenuring distribution for GC cycles.
There are 3 case scenarios:
This enhancement improves visibility into object tenuring during individual GC cycles.
Progress
Issue
Reviewers
Reviewing
Using
gitCheckout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/679/head:pull/679$ git checkout pull/679Update a local copy of the PR:
$ git checkout pull/679$ git pull https://git.openjdk.org/jmc.git pull/679/headUsing Skara CLI tools
Checkout this PR locally:
$ git pr checkout 679View PR using the GUI difftool:
$ git pr show -t 679Using diff file
Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/679.diff
Using Webrev
Link to Webrev Comment