Skip to content

Conversation

@aymane-harmaz
Copy link
Member

@aymane-harmaz aymane-harmaz commented Oct 17, 2025

This change adds a new tab to display the tenuring distribution for GC cycles.

There are 3 case scenarios:

  • Single GC cycle selected: A histogram chart is shown representing the tenuring distribution (total size across ages) for the selected cycle.
  • No GC cycle selected: An informational message is displayed to prompt the user to select a cycle.
  • Multiple GC cycles selected: An informational message is displayed indicating that only a single cycle can be viewed at a time.
    This enhancement improves visibility into object tenuring during individual GC cycles.
Screenshot 2025-10-15 at 16 51 19 Screenshot 2025-10-15 at 16 51 34 Screenshot 2025-10-15 at 16 51 57

Progress

  • Commit message must refer to an issue
  • Change must be properly reviewed (1 review required, with at least 1 Committer)

Issue

  • JMC-6004: Should add tenuring summary to the GC visualization (New Feature - P3)

Reviewers

Reviewing

Using git

Checkout this PR locally:
$ git fetch https://git.openjdk.org/jmc.git pull/679/head:pull/679
$ git checkout pull/679

Update a local copy of the PR:
$ git checkout pull/679
$ git pull https://git.openjdk.org/jmc.git pull/679/head

Using Skara CLI tools

Checkout this PR locally:
$ git pr checkout 679

View PR using the GUI difftool:
$ git pr show -t 679

Using diff file

Download this PR as a diff file:
https://git.openjdk.org/jmc/pull/679.diff

Using Webrev

Link to Webrev Comment

@bridgekeeper
Copy link

bridgekeeper bot commented Oct 17, 2025

👋 Welcome back aharmaz! A progress list of the required criteria for merging this PR into master will be added to the body of your pull request. There are additional pull request commands available for use with this pull request.

@openjdk
Copy link

openjdk bot commented Oct 17, 2025

@aymane-harmaz This change now passes all automated pre-integration checks.

ℹ️ This project also has non-automated pre-integration requirements. Please see the file CONTRIBUTING.md for details.

After integration, the commit message for the final commit will be:

6004: Should add tenuring summary to the GC visualization

Reviewed-by: hirt

You can use pull request commands such as /summary, /contributor and /issue to adjust it as needed.

At the time when this comment was updated there had been no new commits pushed to the master branch. If another commit should be pushed before you perform the /integrate command, your PR will be automatically rebased. If you prefer to avoid any potential automatic rebasing, please check the documentation for the /integrate command for further details.

As you do not have Committer status in this project an existing Committer must agree to sponsor your change. Possible candidates are the reviewers of this PR (@thegreystone) but any other Committer may sponsor as well.

➡️ To flag this PR as ready for integration with the above commit message, type /integrate in a new comment. (Afterwards, your sponsor types /sponsor in a new comment to perform the integration).

@openjdk openjdk bot added the rfr label Oct 17, 2025
@mlbridge
Copy link

mlbridge bot commented Oct 17, 2025

Webrevs

@thegreystone
Copy link
Member

Looks good Aymane! Do you also handle the case where the event is off, so that there aren't any tenuring distribution events available at all?

GarbageCollectionsPage_PAUSE_PHASES_TITLE=Pause Phases
GarbageCollectionsPage_TENURING_DISTRIBUTION_TITLE=Tenuring Distribution
GarbageCollectionsPage_TENURING_DISTRIBUTION_NO_SELECTION_MESSAGE=No valid Selection
GarbageCollectionsPage_TENURING_DISTRIBUTION_MULTI_SELECTION_MESSAGE=Distribution is shown for a single GC cycle
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this can be more specific? "Multiple GC cycles selected. Distribution is only shown for a single GC."

@openjdk openjdk bot added the ready label Oct 22, 2025
@aymane-harmaz
Copy link
Member Author

Looks good Aymane! Do you also handle the case where the event is off, so that there aren't any tenuring distribution events available at all?

I have added in the latest commit checks on tenuring events, if not found, I display the following message for all kind of selections:

NoTenuringEventMessage
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

2 participants