[app-server] refactor: split API types into v1 and v2 #6005
Conversation
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Codex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback".
| // Module declarations for the app-server protocol namespace. | ||
| // Exposes protocol pieces used by `lib.rs` via `pub use protocol::common::*;`. | ||
|
|
||
| pub mod common; | ||
| pub mod v1; | ||
| pub mod v2; |
There was a problem hiding this comment.
Before the refactor all protocol types were exposed directly under protocol::*, allowing callers to import codex_app_server_protocol::protocol::ClientRequest and similar. After the split the new protocol module only declares common, v1, and v2 submodules and nothing re‑exports their contents, so every existing path of the form protocol::Foo now fails to compile even though the commit description advertises a refactor rather than an API break. If maintaining compatibility is desired, re‑export the submodule contents from protocol/mod.rs (e.g. pub use self::common::*;) so the old paths continue to work while still offering protocol::v1 and protocol::v2.
Useful? React with 👍 / 👎.
Makes it easier to figure out which types are defined in the old vs. new API schema.