rate limit errors now provide absolute time #6000
Conversation
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| let suffix = day_suffix(local_reset.day()); | ||
| local_reset | ||
| .format(&format!("%b %-d{suffix}, %Y %-I:%M %p")) | ||
| .to_string() | ||
| } |
There was a problem hiding this comment.
Formatting the retry timestamp with %-I:%M %p drops the seconds field from resets_at. The server sends second-resolution reset times, so if a limit resets at 12:00:30, the UI will now say Try again at 12:00 AM. A user who follows that guidance will still be rate limited for up to another 59 seconds. The previous duration-based messaging stayed accurate in this short window, but this absolute-time version regressed that behavior. We should include the seconds (or otherwise avoid truncating them) when formatting the timestamp.
Useful? React with 👍 / 👎.
|
Codex Review: Didn't find any major issues. Delightful! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
Uh oh!
There was an error while loading. Please reload this page.