[Hygiene] Remove include_view_image_tool config
#5976
Conversation
celia-oai
force-pushed
the
dev/cc/remove-image-tool
branch
from
b9c4701 to
7719432
Compare
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| pub experimental_instructions_file: Option<PathBuf>, | ||
| pub experimental_compact_prompt_file: Option<PathBuf>, | ||
| pub include_apply_patch_tool: Option<bool>, | ||
| pub include_view_image_tool: Option<bool>, | ||
| pub experimental_use_unified_exec_tool: Option<bool>, | ||
| pub experimental_use_exec_command_tool: Option<bool>, |
There was a problem hiding this comment.
Dropping the include_view_image_tool field means any existing config.toml profiles that have include_view_image_tool = false now deserialize without that override (serde just drops the unknown key). Features::from_config therefore sees None and falls back to Feature::ViewImageTool's default of true, so the image tool gets re-enabled. Users who explicitly disabled uploads for a profile will suddenly get them back, which is a serious regression. Please keep accepting the legacy key—e.g. retain the field (or add a #[serde(alias = "include_view_image_tool")]) and map it into tools_view_image—so existing configs remain honored.
Useful? React with 👍 / 👎.
There's still some debate about whether we want to expose
tools.view_imageorfeature.view_imageso those are left unchanged for now, but this oldinclude_view_image_toolconfig is good-to-go. Also updated the doc to reflect thatview_imagetool is now by default true.