Send delegate header #5942
Send delegate header #5942
Conversation
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
|
@codex review |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| #[serde(rename_all = "snake_case")] | ||
| #[ts(rename_all = "snake_case")] |
There was a problem hiding this comment.
Adding #[serde(rename_all = "snake_case")] changes the serialized form of every SubAgentSource value (e.g. Review → review). We already persist SessionSource::SubAgent inside rollout JSONL files, and existing data on disk uses the old casing. After this change serde will refuse to deserialize those records, so code such as read_summary_from_rollout / extract_conversation_summary in codex-rs/app-server/src/codex_message_processor.rs (and the rollout list code) will fail when they call serde_json::from_value::<SessionMeta>. That makes previously recorded subagent sessions unreadable. Please keep the prior variant names (or add backward-compatible deserialization) instead of renaming them outright.
Useful? React with 👍 / 👎.
| .and_then(|v| v.as_str().map(std::string::ToString::to_string)) | ||
| .unwrap_or_else(|| "other".to_string()) | ||
| }; | ||
| req_builder = req_builder.header("x-openai-subagent", subagent); |
There was a problem hiding this comment.
Make sure the infra team is aware of the new header name
| Err(_) => "unknown".to_string(), | ||
| }; | ||
| req_builder = req_builder.header("Codex-Task-Type", task_type); | ||
| // Include subagent header only for subagent sessions. |
There was a problem hiding this comment.
We can actually always have it. It will just give more data
There was a problem hiding this comment.
the absence of it plus the originator give us the same data
Send delegate type header