ignore agent message deltas for the review mode #5937
Conversation
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
https://github.com/openai/codex/blob/778d1669821d9a9fa70c4e4e3eac7a4128eff160/core/src/tasks/review.rs#L123-L126
This pattern no longer checks item: TurnItem::AgentMessage(_), so every ItemCompleted emitted by the reviewer (including tool calls, uploads, etc.) now gets swallowed. Previously we only skipped assistant message completions to avoid re-emitting legacy agent messages; other completions were forwarded so the outer session/UI could mark the item done. With this change, those completions never arrive, so any non-assistant item produced during review will remain stuck in a "running" state. Please reinstate the TurnItem::AgentMessage(_) guard and keep ignoring only the new delta events.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
codex-rs/core/src/tasks/review.rs
Outdated
| item: TurnItem::AgentMessage(_), | ||
| .. | ||
| }) => {} | ||
| EventMsg::ItemCompleted(ItemCompletedEvent { .. }) |
There was a problem hiding this comment.
Actually we need item completed for non-agent message items
The deltas produce the whole json output. ignore them.