Add debug-only slash command for rollout path #5936
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pakrym-oai
reviewed
Oct 30, 2025
codex-rs/tui/src/slash_command.rs
Outdated
| | SlashCommand::Feedback | ||
| | SlashCommand::Quit => true, | ||
|
|
||
| #[cfg(debug_assertions)] |
There was a problem hiding this comment.
is there a way to have #[cfg(debug_assertions)] in fewer places? Maybe only where we filter commands from visible list?
There was a problem hiding this comment.
Matches are inclusive, once it appears in the definition, it should be everywhere.
There was a problem hiding this comment.
What I mean is can we compile this command for all configs and hide for non-debug ones?
There was a problem hiding this comment.
lemme play with it
There was a problem hiding this comment.
@codex code this
There was a problem hiding this comment.
Summary
- Made the
RolloutandTestApprovalslash command variants compile in all builds while preserving their descriptions and task-availability metadata. codex-rs/tui/src/slash_command.rsL28-L81 - Added an
is_visiblehelper so built-in command enumeration filters out debug-only entries outside debug builds, keeping the commands hidden from release users. codex-rs/tui/src/slash_command.rsL84-L97
Testing
- ✅
cargo test -p codex-tui
There was a problem hiding this comment.
@pakrym-oai done
## Summary - add a debug-only `/rollout` slash command that prints the rollout file path or reports when none is known - surface the new command in the slash command metadata and cover it with unit tests - compile the `/rollout` slash command in all builds and hide it from the release command list ## Testing - cargo test -p codex-tui ------ https://chatgpt.com/codex/tasks/task_i_6902bd0edd8083219abc8cd4e24c3fcb
pakrym-oai
reviewed
Oct 30, 2025
codex-rs/tui/src/chatwidget/tests.rs
Outdated
| } | ||
| } | ||
|
|
||
| #[cfg(debug_assertions)] |
There was a problem hiding this comment.
can we remove this too?
pakrym-oai
approved these changes
Oct 30, 2025
aibrahim-oai
deleted the
codex/add-debug-slash-command-for-rollout-path
branch
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
/rolloutslash command that prints the rollout file path or reports when none is known