[exec] Add MCP tool arguments and results #5899
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![chatgpt-codex-connector[bot]](https://cdn.statically.io/img/avatars.githubusercontent.com/in/1144995?s=60&v=4){kind=small}
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
… option type throughout - Change structured_content in McpToolCallItemResult from JsonValue (default empty map) to Option<JsonValue> - Update event processing logic to preserve Option type - Update test to use structured_content: None for empty content - Adjust typescript SDK to use structured_content name and make it optional/unknown
…tion type; clean up unused import
owenlin0
approved these changes
Oct 29, 2025
codex-rs/exec/src/exec_events.rs
Outdated
| pub arguments: JsonValue, | ||
| #[serde(skip_serializing_if = "Option::is_none")] | ||
| pub result: Option<McpToolCallItemResult>, | ||
| #[serde(skip_serializing_if = "Option::is_none")] |
There was a problem hiding this comment.
should we remove these annotations? I think it's worth dropping these going forward
There was a problem hiding this comment.
do we need to deserialize old McpToolCallItems? if so, we'd probably want to add #[serde(default)] so things don't break
There was a problem hiding this comment.
We do not need to deserialize. Removed.
…ExecutionItem and McpToolCallItem
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Extends mcp_tool_call item to include arguments and results.