chore: config editor #5878
Merged
chore: config editor #5878
+926
−1,006
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codex review |
|
Codex Review: Didn't find any major issues. Already looking forward to the next diff. ℹ️ About Codex in GitHubCodex has been enabled to automatically review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. When you sign up for Codex through ChatGPT, Codex can also answer questions or update the PR, like "@codex address that feedback". |
pakrym-oai
reviewed
Oct 29, 2025
pakrym-oai
reviewed
Oct 29, 2025
pakrym-oai
reviewed
Oct 29, 2025
pakrym-oai
reviewed
Oct 29, 2025
pakrym-oai
reviewed
Oct 29, 2025
pakrym-oai
reviewed
Oct 29, 2025
pakrym-oai
approved these changes
Oct 29, 2025
There was a problem hiding this comment.
Beautiful.
Three comments, neither blocking:
- Consider representing config update using a struct that mirrors Config struct. It becomes very clear what exactly is being updated and why.
- Let's assert before/after of config edits against raw strings to ensure formatting isn't messed up.
- Can pick either builder or edit array an use it consistently?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The goal is to have a single place where we actually write files
In a follow-up PR, will move everything config related in a dedicated module and move the helpers in a dedicated file