Skip to content

Added support for sandbox_mode in profiles #5686

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Oct 25, 2025
Merged

Added support for sandbox_mode in profiles #5686

merged 1 commit into from
Oct 25, 2025
+96 −10

Conversation

@etraut-openai
Copy link
Collaborator

@etraut-openai etraut-openai commented Oct 25, 2025 •
edited
Loading

Currently, approval_policy is supported in profiles, but sandbox_mode is not. This PR adds support for sandbox_mode.

Note: a fix for this was submitted in this PR, but the underlying code has changed significantly since then.

This addresses issue #3034
@etraut-openai
Copy link
Collaborator Author

@codex review
@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
@etraut-openai etraut-openai marked this pull request as ready for review October 25, 2025 22:56
@etraut-openai etraut-openai mentioned this pull request Oct 25, 2025
Closed
@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
1 similar comment
@chatgpt-codex-connector
Copy link
Contributor

Codex Review: Something went wrong. Try again later by commenting “@codex review”.

An unknown error occurred
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
@etraut-openai etraut-openai merged commit c124f24 into main Oct 25, 2025
20 checks passed
@etraut-openai etraut-openai deleted the etraut/profile_sandbox_mode branch October 25, 2025 23:52
@github-actions github-actions bot locked and limited conversation to collaborators Oct 25, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants

@etraut-openai @pakrym-oai