Use Option symbol for mac key hints #5582
Merged
+21
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
@codex fix the broken tests |
|
Summary
Testing
|
Summary Made the renders_with_queued_messages snapshot test in status_indicator_widget.rs use a macOS-specific snapshot suffix so the Option-key glyph is only asserted on mac builds while Linux continues to consume the existing snapshot. Added a macOS snapshot that captures the queued-messages view with the ⌥ + ↑ hint so macOS CI has the expected golden output. Testing ✅ just fmt ✅ just fix -p codex-tui ✅ cargo test -p codex-tui -- status_indicator_widget::tests::renders_with_queued_messages
joshka-oai
force-pushed
the
codex/update-text-to-use-on-macos
branch
from
352f19c to
ce9c29c
Compare
tibo-openai
approved these changes
Oct 24, 2025
|
@codex fix all the broken tests again. |
|
Summary
Testing
|
Renamed the macOS snapshot for status_indicator_widget::tests::renders_with_queued_messages to use Insta’s @MacOS suffix so mac runners can pick up the expected ⌥ + ↑ hint rendering without producing new snapshots. Testing ✅ cargo test -p codex-tui -- status_indicator_widget::tests::renders_with_queued_messages
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
https://chatgpt.com/codex/tasks/task_i_68fab7505530832992780a9e13fb707b