Skip to content

Conversation

@apanasenko-oai
Copy link
Collaborator

No description provided.

@apanasenko-oai apanasenko-oai requested review from pkomlev and removed request for pkomlev October 23, 2025 21:48
@apanasenko-oai apanasenko-oai force-pushed the anton_panasenko_raw_messages branch from f635038 to 5cb7f64 Compare October 23, 2025 22:07
match second.msg {
EventMsg::TurnAborted(e) => assert_eq!(TurnAbortReason::Interrupted, e.reason),
other => panic!("unexpected second event: {other:?}"),
loop {
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

wait_for_event?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we don't have CodexConversation and Codex here, refactoring of those tests is out of scope of this changes.

Copy link
Collaborator

@pakrym-oai pakrym-oai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a core integration test that asserts ResponseItems are being emitted ?

@apanasenko-oai apanasenko-oai force-pushed the anton_panasenko_raw_messages branch from 5cb7f64 to 1033d95 Compare October 24, 2025 19:05
@apanasenko-oai apanasenko-oai enabled auto-merge (squash) October 24, 2025 19:06
@apanasenko-oai apanasenko-oai force-pushed the anton_panasenko_raw_messages branch 3 times, most recently from c2195e3 to 5e3cbae Compare October 24, 2025 22:12
@apanasenko-oai apanasenko-oai force-pushed the anton_panasenko_raw_messages branch from 5e3cbae to 00cbd93 Compare October 24, 2025 22:24
@apanasenko-oai apanasenko-oai merged commit 6af83d8 into main Oct 24, 2025
18 of 19 checks passed
@apanasenko-oai apanasenko-oai deleted the anton_panasenko_raw_messages branch October 24, 2025 22:41
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

3 participants