-
Notifications
You must be signed in to change notification settings - Fork 6.1k
[codex][app-server] introduce codex/event/raw_item events #5578
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
f635038 to
5cb7f64
Compare
| match second.msg { | ||
| EventMsg::TurnAborted(e) => assert_eq!(TurnAbortReason::Interrupted, e.reason), | ||
| other => panic!("unexpected second event: {other:?}"), | ||
| loop { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
wait_for_event?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we don't have CodexConversation and Codex here, refactoring of those tests is out of scope of this changes.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a core integration test that asserts ResponseItems are being emitted ?
5cb7f64 to
1033d95
Compare
c2195e3 to
5e3cbae
Compare
5e3cbae to
00cbd93
Compare
No description provided.