Delegate review to codex instance #5572

aibrahim-oai · 2025-10-23T19:24:37Z

In this PR, I am exploring migrating task kind to an invocation of Codex. The main reason would be getting rid off multiple ConversationHistory state and streamlining our context/history management.

This approach depends on opening a channel between the sub-codex and codex. This channel is responsible for forwarding interactive (approvals) and non-interactive events. The task is responsible for handling those events.

This opens the door for implementing codex as a tool, replacing compact and review, and potentially subagents.

One consideration is this code is very similar to app-server specially in the approval part. If in the future we wanted an interactive sub-codex we should consider using codex-mcp

codex-rs/core/src/codex.rs

aibrahim-oai · 2025-10-24T19:45:51Z

@review this

codex-rs/core/src/tasks/mod.rs

codex-rs/core/src/codex_delegate.rs

jif-oai

I like the idea. It would be good to push it slightly further before merging in order to avoid duplicating some logic

codex-rs/core/src/tasks/review.rs

codex-rs/core/src/codex_delegate.rs

codex-rs/core/src/tasks/review.rs

jif-oai

This is way better IMO

A bunch of tests would be cool

jif-oai · 2025-10-28T17:35:37Z

codex-rs/core/templates/review/exit_success.xml

+  <results>
+  {results}
+  </results>
+  </user_action>


What does tab issue mean

The indentation of the file is not correct I think

codex-rs/core/src/codex_delegate.rs

codex-rs/protocol/src/protocol.rs

chatgpt-codex-connector · 2025-10-28T21:29:52Z

💡 Codex Review

https://github.com/openai/codex/blob/6270245a014cbaf466d2bac8474d6ae82f99e665/codex-rs/core/src/tasks/review.rs#L31-L54
Preserve review output in TaskComplete events

The new delegate-based reviewer always returns None from ReviewTask::run (lines 31‑54), so Session::on_task_finished now emits TaskComplete with last_agent_message: None. Exec/front-end processors such as codex-rs/exec/src/event_processor_with_human_output.rs (lines 173‑182, 515‑516) rely on that field and completely ignore ExitedReviewMode, which means /review executed via the CLI no longer prints any findings at all even though the delegate produced them. The previous implementation propagated the final assistant message through run_task, so TaskComplete carried the review summary. Please return an appropriate string (e.g., the delegate’s overall_explanation) so TaskComplete keeps the review output for clients that only look at that field.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aibrahim-oai · 2025-10-29T00:04:34Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/tasks/review.rs

aibrahim-oai · 2025-10-29T00:51:39Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

codex-rs/core/src/codex.rs

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

chatgpt-codex-connector · 2025-10-29T02:24:20Z

codex-rs/core/src/tasks/review.rs

+        };
+        if !cancellation_token.is_cancelled() {
+            exit_review_mode(session.clone_session(), output.clone(), ctx.clone()).await;
+        }
+        None


CLI reviews emit no output after delegate change

The delegate now throws away the reviewer’s final response. In ReviewTask::run (lines 50‑54) the parsed review output is ignored and the task always returns None, so Session::on_task_finished emits TaskComplete { last_agent_message: None }. The only signal that remains is ExitedReviewMode. Clients such as the CLI (codex-rs/exec/src/event_processor_with_human_output.rs lines 156‑205 and 500‑505) render only last_agent_message and currently treat ExitedReviewMode as a no‑op, so invoking /review from the CLI (or other non-TUI frontends) now completes with no review output at all. We need to either return the reviewer’s final text here (as before) or update those clients to consume the structured review event, otherwise reviews outside the TUI are unusable.

Useful? React with 👍 / 👎.

aibrahim-oai · 2025-10-29T02:30:11Z

@codex review this

chatgpt-codex-connector

💡 Codex Review

codex/codex-rs/core/src/codex.rs

Lines 1107 to 1111 in fd7a31c

    
           info!("spawning ghost snapshot task"); 
        
           let task = GhostSnapshotTask::new(token); 
        
           Arc::new(task) 
        
               .run( 
        
                   Arc::new(SessionTaskContext::new(self.clone())),

Honor GhostCommit flag before spawning ghost snapshots

Lines 1107‑1111 unconditionally spawn GhostSnapshotTask every time maybe_start_ghost_snapshot runs, and run_task still invokes this helper for every turn (line 1675). The guard that previously short‑circuited when Feature::GhostCommit was disabled or when the turn was a review thread was removed, so ghost snapshots now run even when the feature is turned off in the session config. That causes unexpected repo writes and extra approvals for users who explicitly disabled snapshots. Please restore the feature/review checks so the background task only runs when snapshots are enabled.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

aibrahim-oai · 2025-10-29T18:08:16Z

@codex review this

chatgpt-codex-connector · 2025-10-29T18:17:13Z

💡 Codex Review

codex/codex-rs/core/src/tasks/review.rs

Lines 104 to 112 in 7b729a5

    
           let mut prev_agent_message: Option<Event> = None; 
        
           while let Ok(event) = receiver.recv().await { 
        
               match event.clone().msg { 
        
                   EventMsg::AgentMessage(_) => { 
        
                       if let Some(prev) = prev_agent_message.take() { 
        
                           session 
        
                               .clone_session() 
        
                               .send_event(ctx.as_ref(), prev.msg) 
        
                               .await;

Preserve review output for non‑TUI clients

The new delegate never forwards the reviewer’s final response. In process_review_events the current AgentMessage is stored in prev_agent_message and only sent once another AgentMessage arrives (lines 104‑112), and ReviewTask::run now always returns None, so the parent session emits TaskComplete with no last_agent_message. A review normally emits exactly one AgentMessage, so nothing ever reaches the parent. The CLI/exec processors (codex-rs/exec/src/event_processor_with_human_output.rs lines 183‑220 and 505‑516) only render AgentMessage events or TaskComplete.last_agent_message and explicitly ignore ExitedReviewMode, which means running /review in codex-cli now produces no findings (and --output files stay empty). The final AgentMessage needs to be forwarded—or injected into the TaskComplete payload—so non‑TUI clients still receive the review results.

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

jif-oai

Looks pretty good
A few comment left and our async discussion on the source of the SubAgent (to be piped to the client). Then, looks good to me
Ping me if you want another review

codex-rs/core/src/tasks/review.rs

codex-rs/core/src/codex_delegate.rs

codex-rs/core/tests/suite/codex_delegate.rs

codex-rs/protocol/src/protocol.rs

codex-rs/core/tests/suite/codex_delegate.rs

codex-rs/core/src/codex_delegate.rs

aibrahim-oai changed the title ~~Proto on main~~ Oct 23, 2025

aibrahim-oai commented Oct 23, 2025

View reviewed changes

codex-rs/core/src/codex.rs Outdated Show resolved Hide resolved

pakrym-oai reviewed Oct 24, 2025

View reviewed changes

codex-rs/core/src/tasks/mod.rs Outdated Show resolved Hide resolved

pakrym-oai reviewed Oct 24, 2025

View reviewed changes

codex-rs/core/src/codex_delegate.rs Show resolved Hide resolved

jif-oai reviewed Oct 27, 2025

View reviewed changes

aibrahim-oai force-pushed the proto-on-main branch from adb72db to 6aad461 Compare October 28, 2025 00:13

jif-oai reviewed Oct 28, 2025

View reviewed changes

pakrym-oai reviewed Oct 28, 2025

View reviewed changes

codex-rs/protocol/src/protocol.rs Outdated Show resolved Hide resolved

aibrahim-oai marked this pull request as ready for review October 28, 2025 21:18

aibrahim-oai force-pushed the proto-on-main branch from 6270245 to 2ff1aa3 Compare October 28, 2025 21:20

proto-on-main: squash 20 commits since base of main

159532a

aibrahim-oai force-pushed the proto-on-main branch from 2ff1aa3 to 159532a Compare October 28, 2025 21:25

aibrahim-oai added 5 commits October 28, 2025 14:36

rebase

4a84559

rebase

62e79c4

test

45fda44

test

e6005db

tests

ededc83

wait

74bcb67

chatgpt-codex-connector bot reviewed Oct 29, 2025

View reviewed changes

codex-rs/core/src/tasks/review.rs Show resolved Hide resolved

codex-rs/core/src/tasks/review.rs Show resolved Hide resolved

aibrahim-oai added 2 commits October 28, 2025 17:44

shutdown

8016272

review

3d4a3ba

chatgpt-codex-connector bot reviewed Oct 29, 2025

View reviewed changes

codex-rs/core/src/codex.rs Show resolved Hide resolved

aibrahim-oai added 2 commits October 28, 2025 18:46

use Codex

524b566

shutdown

4ddabaa

aibrahim-oai force-pushed the proto-on-main branch from 7200de2 to 4ddabaa Compare October 29, 2025 02:00

shutdown

55840a2

chatgpt-codex-connector bot reviewed Oct 29, 2025

View reviewed changes

clean

fd7a31c

chatgpt-codex-connector bot reviewed Oct 29, 2025

View reviewed changes

aibrahim-oai added 4 commits October 28, 2025 19:58

Merge branch 'main' into proto-on-main

c58b192

timeout

4547642

fix lock

ba4fe07

fix lock

3d620bd

aibrahim-oai changed the title ~~Prototype to delegate review to codex instance~~ Oct 29, 2025

aibrahim-oai added 4 commits October 29, 2025 08:13

clean task kind

7d30718

clean task kind

24961d1

task types

2a4c363

Merge branch 'main' into proto-on-main

7b729a5

jif-oai approved these changes Oct 29, 2025

View reviewed changes

codex-rs/core/src/tasks/review.rs Outdated Show resolved Hide resolved

codex-rs/core/src/codex_delegate.rs Outdated Show resolved Hide resolved

codex-rs/core/src/codex_delegate.rs Outdated Show resolved Hide resolved

codex-rs/core/tests/suite/codex_delegate.rs Outdated Show resolved Hide resolved

aibrahim-oai added 3 commits October 29, 2025 11:47

guard back and more information in source

a9381fb

feedback

7092b7f

Merge branch 'main' into proto-on-main

b6cc12d

pakrym-oai reviewed Oct 29, 2025

View reviewed changes

codex-rs/protocol/src/protocol.rs Show resolved Hide resolved

pakrym-oai reviewed Oct 29, 2025

View reviewed changes

codex-rs/core/tests/suite/codex_delegate.rs Outdated Show resolved Hide resolved

pakrym-oai reviewed Oct 29, 2025

View reviewed changes

codex-rs/core/src/codex_delegate.rs Outdated Show resolved Hide resolved

pakrym-oai reviewed Oct 29, 2025

View reviewed changes

codex-rs/core/src/codex_delegate.rs Show resolved Hide resolved

pakrym-oai approved these changes Oct 29, 2025

View reviewed changes

aibrahim-oai added 2 commits October 29, 2025 13:13

source

77983dd

get back tests

b295fbc

aibrahim-oai enabled auto-merge (squash) October 29, 2025 21:04

aibrahim-oai merged commit 13e1d03 into main Oct 29, 2025
62 of 67 checks passed

aibrahim-oai deleted the proto-on-main branch October 29, 2025 21:04

github-actions bot locked and limited conversation to collaborators Oct 29, 2025

	info!("spawning ghost snapshot task");
	let task = GhostSnapshotTask::new(token);
	Arc::new(task)
	.run(
	Arc::new(SessionTaskContext::new(self.clone())),

Delegate review to codex instance #5572

Delegate review to codex instance #5572

Conversation

aibrahim-oai commented Oct 23, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

aibrahim-oai commented Oct 24, 2025

Uh oh!

Uh oh!

jif-oai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

jif-oai left a comment

Choose a reason for hiding this comment

jif-oai Oct 28, 2025

Choose a reason for hiding this comment

aibrahim-oai Oct 29, 2025

Choose a reason for hiding this comment

jif-oai Oct 29, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

chatgpt-codex-connector bot commented Oct 28, 2025

💡 Codex Review

aibrahim-oai commented Oct 29, 2025

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

aibrahim-oai commented Oct 29, 2025

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

chatgpt-codex-connector bot Oct 29, 2025

Choose a reason for hiding this comment

aibrahim-oai commented Oct 29, 2025

chatgpt-codex-connector bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

aibrahim-oai commented Oct 29, 2025

chatgpt-codex-connector bot commented Oct 29, 2025

💡 Codex Review

jif-oai left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Labels

4 participants

aibrahim-oai commented Oct 23, 2025 •

edited

Loading