-
Notifications
You must be signed in to change notification settings - Fork 6.1k
feat(tui): clarify Windows auto mode requirements #5568
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
656498b to
91d4555
Compare
This comment was marked as outdated.
This comment was marked as outdated.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Want to clarify the default approval mode!
|
CI failures seem unrelated? I restarted the failed jobs |
|
Updated flow including the proper read-only downgrade: Screen.Recording.2025-10-23.at.7.56.35.PM.mov |
|
Fixes: 1. codex-coreFailing test: config::tests::add_dir_override_extends_workspace_writable_roots ——— 2. codex-execFailing test: suite::resume::exec_resume_preserves_cli_configuration_overrides ——— 3. codex-tuiFailing test: chatwidget::tests::approvals_selection_popup_snapshot |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some small copy stuff but code LGTM
| in the workspace. Codex requires approval to work | ||
| outside the workspace or access network | ||
| Requires Windows Subsystem for Linux (WSL). Show | ||
| installation instructions... |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The no-period + newline combo here feels a bit weird. Should we just switch the defaults to sentence-case?
d452a86 to
1644d99
Compare
Warn native Windows users that the Auto preset requires WSL and show the WSL install steps in a dedicated popup.
- expose a structured sandbox policy resolution that flags Windows downgrades\n- show a banner in the approvals popup directing users to WSL or Full Access
Update Windows-only assertions to accept the sandbox downgrade and regenerate the approvals popup snapshot to include the WSL hint.
1644d99 to
1b3e528
Compare
Summary
workspace-writeconfigs back to read-only, surface the forced downgrade in the approvals popup,and funnel users toward WSL or Full Access.
platforms.
confirmation.
exec, TUI) to reflect the new behavior; provide a Windows-only approvals snapshot.
Testing