Skip to content

Add CodexHttpClient wrapper with request logging #5564

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Oct 24, 2025
Merged

Add CodexHttpClient wrapper with request logging #5564

merged 2 commits into from
Oct 24, 2025

Conversation

@pakrym-oai
Copy link
Collaborator

Summary

  • wrap the default reqwest::Client inside a new CodexHttpClient/CodexRequestBuilder pair and log the HTTP method, URL, and status for each request
  • update the auth/model/provider plumbing to use the new builder helpers so headers and bearer auth continue to be applied consistently
  • add the shared http dependency that backs the header conversion helpers

Testing

  • CODEX_SANDBOX=seatbelt CODEX_SANDBOX_NETWORK_DISABLED=1 cargo test -p codex-core
  • CODEX_SANDBOX=seatbelt CODEX_SANDBOX_NETWORK_DISABLED=1 cargo test -p codex-chatgpt
  • CODEX_SANDBOX=seatbelt CODEX_SANDBOX_NETWORK_DISABLED=1 cargo test -p codex-tui

https://chatgpt.com/codex/tasks/task_i_68fa5038c17483208b1148661c5873be
@pakrym-oai
core/client.rs: remove duplicate debug logging for response status
19e8b7d 
core/default_client.rs: centralize HTTP method/url handling and improve request debug logging
@pakrym-oai pakrym-oai enabled auto-merge (squash) October 24, 2025 03:56
@pakrym-oai pakrym-oai disabled auto-merge October 24, 2025 16:47
@pakrym-oai pakrym-oai merged commit 061862a into main Oct 24, 2025
31 of 36 checks passed
@pakrym-oai pakrym-oai deleted the codex/wrap-default_client-in-custom-client-struct branch October 24, 2025 16:47
@github-actions github-actions bot locked and limited conversation to collaborators Oct 24, 2025
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

codex

3 participants

@pakrym-oai @tibo-openai