Handle cancelling/aborting while processing a turn #5543
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@codex review this |
pakrym-oai
reviewed
Oct 22, 2025
pakrym-oai
reviewed
Oct 22, 2025
pakrym-oai
reviewed
Oct 22, 2025
| for window in input.windows(2) { | ||
| let current = &window[0]; | ||
| let next = &window[1]; | ||
| if current.get("type").and_then(|v| v.as_str()) == Some("function_call") |
There was a problem hiding this comment.
are there some universally useful test helper we can add to make this and other tests more readable?
There was a problem hiding this comment.
I'll look into it.
pakrym-oai
reviewed
Oct 22, 2025
pakrym-oai
reviewed
Oct 22, 2025
|
Codex Review: Didn't find any major issues. Another round soon, please! ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
If Codex has suggestions, it will comment; otherwise it will react with 👍. Codex can also answer questions or update the PR. Try commenting "@codex address that feedback". |
pakrym-oai
reviewed
Oct 22, 2025
pakrym-oai
reviewed
Oct 22, 2025
jif-oai
approved these changes
Oct 23, 2025
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently we collect all all turn items in a vector, then we add it to the history on success. This result in losing those items on errors including aborting
ctrl+c.This PR:
Admittedly, this logic is an ad-hoc logic that doesn't handle a lot of error edge cases. The right thing to do is recording to the history on the spot as
items/tool calls outputcome. However, this isn't possible because of having differenttask_kindthat has differentconversation_histories. Thetry_run_turnhas no idea what thread are we using. We cannot also pass anarcto theconversation_historiesbecause it's a private element ofstate.That's said,
abortis the most common case and we should cover it until we removetask kind