-
Notifications
You must be signed in to change notification settings - Fork 6.1k
Windows Sandbox - Alpha version #4905
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Windows Sandbox - Alpha version #4905
Conversation
f459bdf to
7b8fcc2
Compare
|
@codex review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codex Review
Here are some automated review suggestions for this pull request.
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
…d update smoketests
f0f7671 to
2ffad0b
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As requested, I focused on the code outside of the windows-sandbox crate. The PR touches parts of the code base that I'm not super familiar with, but it looks good to me. It's a nice, clean implementation, and the parts that I reviewed look pretty straightforward.
commands inside a Windows restricted-token sandbox, including ACL management, capability SID provisioning, network lockdown, and output capture
(windows-sandbox-rs/src/lib.rs:167, windows-sandbox-rs/src/main.rs:54).
SandboxType::WindowsRestrictedToken, the in-process execution path, and platform sandbox selection now honor the flag (core/src/features.rs:47,
core/src/config.rs:1224, core/src/safety.rs:19, core/src/sandboxing/mod.rs:69, core/src/exec.rs:79, core/src/exec.rs:172).
Cargo.toml:91, core/Cargo.toml:86).
on the platform (scripts/setup-windows.ps1:1).
binary (windows-sandbox-rs/sandbox_smoketests.py:1).