decompose-actions: Remove needless asynchrony

Credit: @iarna

Author: iarna

lib/install/decompose-actions.js

@@ -1,33 +1,33 @@
 'use strict'
 var validate = require('aproba')
-var asyncMap = require('slide').asyncMap
 var npm = require('../npm.js')
 
 module.exports = function (differences, decomposed, next) {
   validate('AAF', arguments)
-  asyncMap(differences, function (action, done) {
+  differences.forEach((action) => {
     var cmd = action[0]
     var pkg = action[1]
     switch (cmd) {
       case 'add':
-        addSteps(decomposed, pkg, done)
+        addSteps(decomposed, pkg)
         break
       case 'update':
-        updateSteps(decomposed, pkg, done)
+        updateSteps(decomposed, pkg)
         break
       case 'move':
-        moveSteps(decomposed, pkg, done)
+        moveSteps(decomposed, pkg)
         break
       case 'remove':
-        removeSteps(decomposed, pkg, done)
+        removeSteps(decomposed, pkg)
         break
       default:
-        defaultSteps(decomposed, cmd, pkg, done)
+        defaultSteps(decomposed, cmd, pkg)
     }
-  }, next)
+  })
+  next()
 }
 
-function addSteps (decomposed, pkg, done) {
+function addSteps (decomposed, pkg) {
   if (!pkg.fromBundle && !pkg.isLink) {
     decomposed.push(['fetch', pkg])
     decomposed.push(['extract', pkg])
@@ -42,31 +42,26 @@ function addSteps (decomposed, pkg, done) {
     decomposed.push(['finalize', pkg])
   }
   decomposed.push(['refresh-package-json', pkg])
-  done()
 }
 
-function updateSteps (decomposed, pkg, done) {
-  removeSteps(decomposed, pkg.oldPkg, () => {
-    addSteps(decomposed, pkg, done)
-  })
+function updateSteps (decomposed, pkg) {
+  removeSteps(decomposed, pkg.oldPkg)
+  addSteps(decomposed, pkg)
 }
 
-function removeSteps (decomposed, pkg, done) {
+function removeSteps (decomposed, pkg) {
   decomposed.push(['unbuild', pkg])
   decomposed.push(['remove', pkg])
-  done()
 }
 
-function moveSteps (decomposed, pkg, done) {
+function moveSteps (decomposed, pkg) {
   decomposed.push(['move', pkg])
   decomposed.push(['build', pkg])
   decomposed.push(['install', pkg])
   decomposed.push(['postinstall', pkg])
   decomposed.push(['refresh-package-json', pkg])
-  done()
 }
 
-function defaultSteps (decomposed, cmd, pkg, done) {
+function defaultSteps (decomposed, cmd, pkg) {
   decomposed.push([cmd, pkg])
-  done()
 }