Feature/mwe 183 cookie consent #120
Merged
+152
−94
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…nt implementation
…eys for iteration
vycos-zen
previously approved these changes
Nov 1, 2025
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the cookie consent feature by extracting types, services, and components into separate files, and updates the UI to use a new expandable cookie option design with improved styling based on a design system.
- Refactored cookie consent logic by separating types, services, and cookie options into dedicated modules
- Introduced a new expandable
CookieOptionSegmentcomponent with collapsible details - Updated styling to use semantic color tokens (bg-primary, bg-secondary, etc.) instead of hardcoded colors
Reviewed Changes
Copilot reviewed 13 out of 36 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| packages-ui/mwe-ui-core/src/core/types/CookieConsent.ts | Defines new types for cookie consent data and options |
| packages-ui/mwe-ui-core/src/core/services/CookieService.ts | Refactors service to import types externally and renames export to camelCase |
| packages-ui/mwe-ui-core/src/core/CookieOptions.ts | Extracts cookie options configuration into a separate file |
| packages-ui/mwe-ui-core/src/core/components/CookieOptionSegment.tsx | New expandable component for displaying individual cookie options |
| packages-ui/mwe-ui-core/src/core/components/CookieConsent.tsx | Refactored to use extracted modules and new component |
| packages-ui/mwe-ui-core/src/ui-interactive/components/Button.tsx | Simplified imports and destructured props |
| packages-ui/mwe-ui-core/src/ui-interactive/components/CheckBox.tsx | Added bg-secondary class |
| apps-ui/john-glenn-ui/app/layout.tsx | Integrated ClientRoot component |
| apps-ui/john-glenn-ui/app/ClientRoot.tsx | New client-side component wrapper for CookieConsent |
| package.json | Added @tailwindcss/typography dependency |
Files not reviewed (1)
- .pnp.cjs: Language not supported
Comments suppressed due to low confidence (2)
packages-ui/mwe-ui-core/src/ui-interactive/components/Button.tsx:13
- The
typeprop is destructured from ButtonProps but not used. The button always hastype=\"button\"hardcoded, ignoring thetypeprop passed by the caller. Either use thetypeprop or remove it from the interface.
packages-ui/mwe-ui-core/src/ui-interactive/components/Button.tsx:13 - The
onClickprop is destructured from ButtonProps but never attached to the button element. AddonClick={onClick}to the button attributes to make it functional.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| @@ -0,0 +1,22 @@ | |||
| import { CookieOption} from './types' | |||
There was a problem hiding this comment.
Missing space before closing brace in import statement. Should be { CookieOption } instead of { CookieOption}.
Suggested change
| import { CookieOption} from './types' | |
| import { CookieOption } from './types' |
| /> | ||
| </div> | ||
| </> | ||
| )} |
There was a problem hiding this comment.
Trailing whitespace detected after the closing parenthesis. Remove the extra spaces for code cleanliness.
Suggested change
| )} | |
| )} |
packages-ui/mwe-ui-core/src/ui-interactive/components/Button.tsx
Outdated
Show resolved
Hide resolved
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.