Trace requests that end in network errors for better debugging

[marktheunissen]

Currently the madmin SDK will retry on network errors, silently, even when TraceOn() has been called.

This PR changes the trace output so that network errors are shown to the developer, and it's more obvious that a retry has occurred.

This is useful in integration testing.

Good request (current behavior):

Network error:

[Copilot]

Pull Request Overview

This PR enhances HTTP tracing functionality by adding support for dumping network errors in addition to successful HTTP responses. When network errors occur during HTTP requests, they are now logged to the trace output with contextual information.

Key changes:

• Modified dumpHTTP method signature to accept a netErr parameter for network errors
• Added network error logging logic that displays error details in trace output
• Updated call sites to dump HTTP traces when network errors occur, not just on successful responses

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 2 comments.

File	Description
api.go	Updated AdminClient.dumpHTTP to handle network errors and added error dumping in the do method's error path
anonymous-api.go	Updated AnonymousClient.dumpHTTP to handle network errors and added error dumping in the do method's error path

---

��� Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[shtripat]

lgtm